Honor explicit Nyquist indent direction near imaginary axis#1223
Merged
murrayrm merged 1 commit intoJun 8, 2026
Conversation
Preserve automatic near-axis indentation when no direction is passed, but let explicit left/right override pole-side selection for poles within the indent radius. Fixes python-control#1194
|
coverage: 94.73% (-0.006%) from 94.736% — marko1olo:fix-nyquist-indent-direction into python-control:main |
Contributor
Author
|
I checked the remaining failed check. The test suite itself passed, including the Nyquist tests: The job failed afterward in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1194.
Summary
indent_directionwas explicitly suppliedleft/rightfor poles withinindent_radius, even when the pole has a small nonzero real partrightandleftmust produce opposite real offsetsTests
MPLBACKEND=Agg python -m pytest control\tests\nyquist_test.py::test_nyquist_indent_near_imaginary_axis control\tests\nyquist_test.py::test_nyquist_indent_default control\tests\nyquist_test.py::test_nyquist_indent_dont control\tests\nyquist_test.py::test_nyquist_indent_do control\tests\nyquist_test.py::test_nyquist_indent_left control\tests\nyquist_test.py::test_nyquist_indent_im control\tests\nyquist_test.py::test_no_indent_pole -qMPLBACKEND=Agg python -m pytest control\tests\nyquist_test.py -q(24 passed, 1 existing xpass, 1 warning)python -m ruff check control\freqplot.py control\tests\nyquist_test.pypython -m compileall -q control\freqplot.py control\tests\nyquist_test.pygit diff --check