Skip to content

REBASE: use __call__ instead of evalfr in lti system classes #499

Closed
murrayrm wants to merge 1 commit into
python-control:masterfrom
murrayrm:call-method_rebase
Closed

REBASE: use __call__ instead of evalfr in lti system classes #499
murrayrm wants to merge 1 commit into
python-control:masterfrom
murrayrm:call-method_rebase

Conversation

@murrayrm

@murrayrm murrayrm commented Jan 6, 2021

Copy link
Copy Markdown
Member

This is a rebase of PR #449.

@murrayrm

murrayrm commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

Requesting a second look from @bnavigator, @sawyerbfuller just to make sure it all still looks OK. Will merge as soon as they approve.

@bnavigator

bnavigator commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

The change for frd_test.py::test_eval() got lost.

Fix in 73fc6a6

Comment thread control/tests/margin_test.py
Comment thread control/tests/statesp_test.py
Comment thread control/tests/statesp_test.py
Comment thread control/tests/statesp_test.py
Comment thread control/tests/xferfcn_test.py
Comment thread control/tests/xferfcn_test.py
@bnavigator

Copy link
Copy Markdown
Contributor

@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you could merge (not pick!) the commit into your origin:call-method. (See sawyerbfuller#1 (comment))

Let's also wait on Travis. The scheduler is particularly slow today.

@coveralls

coveralls commented Jan 6, 2021

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 87.32% when pulling 195bec3 on murrayrm:call-method_rebase into 4103688 on python-control:master.

@bnavigator

Copy link
Copy Markdown
Contributor

I pushed your rebase into #449. We can continue discussion in the original PR.

@bnavigator bnavigator closed this Jan 6, 2021
@murrayrm

murrayrm commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

Thanks, @bnavigator.

@sawyerbfuller

Copy link
Copy Markdown
Contributor

@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you could merge (not pick!) the commit into your origin:call-method.

is this still relevant now that #449 is now (mostly) rebased?

@bnavigator

Copy link
Copy Markdown
Contributor

I addressed all my comments and pushed into your branch. Even with your small edit in between. Hooray for git 😀

@murrayrm murrayrm deleted the call-method_rebase branch January 14, 2021 07:05
@murrayrm murrayrm modified the milestone: 0.9.0 Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants