Skip to content

Fix complex arcsin test on Windows #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eriknw merged 2 commits into from
Feb 21, 2023
Merged

Fix complex arcsin test on Windows #394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74fc550
Fix complex arcsin test on Windows
eriknw Feb 21, 2023
bc0f3cb
undo
eriknw Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions graphblas/tests/test_numpyops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ def test_npunary():
"INT64": {"reciprocal"},
"FC64": {"ceil", "floor", "trunc"},
}
if suitesparse and is_win:
if suitesparse and is_win and gb.config["mapnumpy"]:
# asin and asinh are known to be wrong in SuiteSparse:GraphBLAS
# due to limitation of MSVC with complex
blocklist["FC64"].update({"asin", "asinh"})
blocklist["FC32"] = {"asin", "asinh"}
blocklist["FC64"].update({"arcsin", "arcsinh"})
blocklist["FC32"] = {"arcsin", "arcsinh"}
isclose = gb.binary.isclose(1e-6, 0)
for gb_input, np_input in data:
for unary_name in sorted(npunary._unary_names):
Expand Down