Skip to content

Fix parse_lpo_and_dwpp not raising ValueError when disable_web_page_preview=False #5268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshil21 merged 3 commits into from
Jun 17, 2026
+11 −1
Merged

Fix parse_lpo_and_dwpp not raising ValueError when disable_web_page_preview=False #5268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
902120f
Fix parse_lpo_and_dwpp not raising when disable_web_page_preview=False
JSap0914 Jun 17, 2026
f889c0a
chore: add chango fragment
JSap0914 Jun 17, 2026
9d5866b
apply review suggestion: chango fragment wording
JSap0914 Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changes/unreleased/5268.GKZnfBkMcLqBC4rTgznsnY.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
bugfixes = "Fixed ``parse_lpo_and_dwpp`` silently overwriting ``link_preview_options`` when ``disable_web_page_preview=False``."
[[pull_requests]]
uid = "5268"
author_uids = ["JSap0914"]
closes_threads = []
2 changes: 1 addition & 1 deletion src/telegram/_utils/argumentparsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def parse_lpo_and_dwpp(
"""Wrapper around warn_about_deprecated_arg_return_new_arg. Takes care of converting
disable_web_page_preview to LinkPreviewOptions.
"""
if disable_web_page_preview and link_preview_options:
if disable_web_page_preview is not None and link_preview_options:
raise ValueError(
"Parameters `disable_web_page_preview` and `link_preview_options` are mutually "
"exclusive."
Expand Down
5 changes: 5 additions & 0 deletions tests/_inline/test_inputtextmessagecontent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ def test_mutually_exclusive(self):
InputTextMessageContent(
"text", disable_web_page_preview=True, link_preview_options=LinkPreviewOptions()
)
# disable_web_page_preview=False is also an explicit value and must conflict
with pytest.raises(ValueError, match="`link_preview_options` are mutually exclusive"):
InputTextMessageContent(
"text", disable_web_page_preview=False, link_preview_options=LinkPreviewOptions()
)

def test_disable_web_page_preview_deprecation(self):
itmc = InputTextMessageContent("text", disable_web_page_preview=True)
Expand Down
Loading