PENDING: Shikra: Add display support for CQM and CQS targets by naala-qcom · Pull Request #749 · qualcomm-linux/kernel

naala-qcom · 2026-06-21T13:30:02Z

This patch series enables the display in shikra for CQM and CQS target.

CRs-Fixed: 4566067

Add the SoC-level display subsystem nodes for Shikra: MDSS wrapper, DPU display controller, DSI host controller, and 14nm DSI PHY. Shikra uses DPU 6.5 hardware (same as QCM2290). Platform-specific compatible strings are used as the primary match with QCM2290 fallbacks to reuse the existing driver support. The dispcc clock inputs for the DSI byte and pixel PLLs are wired from mdss_dsi0_phy. Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>

…7807s panel Enable the Shikra MDSS display subsystem on the CQM EVK board and add the ili7807s panel node. Pin pm4125_l5 to 1.232V with regulator-allow-set-load for DSI PHY PLL stability. Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>

Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module, used on the Shikra CQM EVK board. Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>

Enable the DLC0697 MIPI DSI display panel on the Shikra CQS EVK. Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>

qlijarvis · 2026-06-21T14:01:32Z

PR #749 — validate-patch

PR: #749

Verdict	Issues	Detailed Report
⚠️	0	Full report

Final Summary

Lore link present: No — PENDING: prefix indicates patches not yet posted or awaiting upstream acceptance; no lore links in commit messages
Lore link matches PR commits: N/A — no lore links to compare against
Upstream patch status: Not upstream — all 4 commits carry PENDING: prefix indicating they are either not yet submitted or awaiting upstream review/acceptance
PR present in qcom-next: Not checked — validation scope limited to patch correctness and upstream alignment per instructions

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #749 - Add MDSS display subsystem support for Shikra
Upstream commit: N/A (PENDING patches)
Verdict: ⚠️ PARTIAL

Commit 1/4: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem

Commit Message

Check Status Note

Subject matches upstream N/A PENDING prefix indicates not yet upstream

Body preserves rationale ✅ Clear description of hardware added and design choices

Fixes tag present/correct N/A New feature, no Fixes tag needed

Authorship preserved ✅ Author: Nabige Aala nabige.aala@oss.qualcomm.com

Backport note (if applicable) N/A Not a backport

Diff

File Status Notes

arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Adds MDSS, DPU, DSI controller, and PHY nodes with proper bindings

Commit 2/4: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel

Commit Message

Check Status Note

Subject matches upstream N/A PENDING prefix indicates not yet upstream

Body preserves rationale ✅ Explains board enablement and regulator configuration

Fixes tag present/correct N/A New feature, no Fixes tag needed

Authorship preserved ✅ Author: Nabige Aala nabige.aala@oss.qualcomm.com

Backport note (if applicable) N/A Not a backport

Diff

File Status Notes

arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ✅ Enables MDSS, adds panel node, configures regulators and pinctrl

Commit 3/4: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

Commit Message

Check Status Note

Subject matches upstream N/A PENDING prefix indicates not yet upstream

Body preserves rationale ✅ Explains why config is needed (used on Shikra CQM EVK)

Fixes tag present/correct N/A New feature, no Fixes tag needed

Authorship preserved ⚠️ Author email changed: naala@qti.qualcomm.com (vs nabige.aala@oss.qualcomm.com in commits 1-2)

Backport note (if applicable) N/A Not a backport

Diff

File Status Notes

arch/arm64/configs/defconfig ✅ Adds CONFIG_DRM_PANEL_ILITEK_ILI7807S=m in alphabetical order

Commit 4/4: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

Commit Message

Check Status Note

Subject matches upstream N/A PENDING prefix indicates not yet upstream

Body preserves rationale ✅ Brief but clear description of panel enablement

Fixes tag present/correct N/A New feature, no Fixes tag needed

Authorship preserved ⚠️ Author email: naala@qti.qualcomm.com (inconsistent with commits 1-2)

Backport note (if applicable) N/A Not a backport

Diff

File Status Notes

arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts ✅ Enables MDSS on CQS EVK, mirrors CQM EVK structure

Issues

Author email inconsistency: Commits 1-2 use nabige.aala@oss.qualcomm.com while commits 3-4 use naala@qti.qualcomm.com. This should be consistent across the series.

Missing Link tags: PENDING patches typically should include a Link: tag pointing to the lore.kernel.org discussion thread once posted upstream. These commits lack any Link tags.

No upstream reference: The PENDING prefix indicates these patches are intended for upstream submission but haven't been posted yet, or are awaiting review. There's no indication of:

Whether they've been posted to linux-arm-msm@vger.kernel.org

Review status if posted

Dependencies on other patch series

Signed-off-by only: Kernel patches typically accumulate additional tags during review (Reviewed-by, Acked-by, Tested-by). The absence suggests these haven't been through upstream review yet.

Verdict

This is a PENDING patch series for new Shikra display hardware support. The patches are technically sound with proper DT bindings and logical structure, but show author email inconsistency and lack upstream submission evidence. Suitable for internal integration but should not be considered upstream-ready without addressing the authorship issue and completing upstream submission.

Final Summary

Lore link present: No — PENDING: prefix indicates patches not yet posted or awaiting upstream acceptance; no lore links in commit messages

Lore link matches PR commits: N/A — no lore links to compare against

Upstream patch status: Not upstream — all 4 commits carry PENDING: prefix indicating they are either not yet submitted or awaiting upstream review/acceptance

PR present in qcom-next: Not checked — validation scope limited to patch correctness and upstream alignment per instructions

qlijarvis · 2026-06-21T14:01:33Z

PR #749 — checker-log-analyzer

PR: #749
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27905934739

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	All 4 commits passed with 0 errors, 0 warnings
dt-binding-check	⏭️	Skipped - no changes in Documentation/devicetree/bindings
dtb-check	❌	Schema validation failure: iommus property too short
sparse-check	⏭️	Skipped - no C code changes
check-uapi-headers	⏭️	Skipped - no UAPI header changes
check-patch-compliance	❌	All 4 commits use PENDING: prefix (not UPSTREAM:/FROMLIST:)
tag-check	N/A	Not applicable for this branch
qcom-next-check	⚠️	PENDING: commits present (expected for non-qcom-next branches)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #749 - PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27905934739

Checker Result Summary

checkpatch ✅ All 4 commits passed with 0 errors, 0 warnings

dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings

dtb-check ❌ Schema validation failure: iommus property too short

sparse-check ⏭️ Skipped - no C code changes

check-uapi-headers ⏭️ Skipped - no UAPI header changes

check-patch-compliance ❌ All 4 commits use PENDING: prefix (not UPSTREAM:/FROMLIST:)

tag-check N/A Not applicable for this branch

qcom-next-check ⚠️ PENDING: commits present (expected for non-qcom-next branches)

❌ dtb-check

Root cause: The iommus property in the MDSS node uses a 3-cell format <&apps_smmu 0x420 0x2>, but the qcom,qcm2290-mdss.yaml schema expects a 4-cell format per the SMMU binding.

Failure details:
/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb: 
  display-subsystem@5e00000 (qcom,shikra-mdss): iommus: [[41, 1056, 2]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dtb: 
  display-subsystem@5e00000 (qcom,shikra-mdss): iommus: [[41, 1056, 2]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: 
  display-subsystem@5e00000 (qcom,shikra-mdss): iommus: [[40, 1056, 2]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#
Fix: Update the iommus property in arch/arm64/boot/dts/qcom/shikra.dtsi:3025 to use 4 cells instead of 3. Change:
-			iommus = <&apps_smmu 0x420 0x2>;
+			iommus = <&apps_smmu 0x420 0x0 0x2>;
The SMMU binding for ARM SMMUv2/v3 requires 4 cells: <phandle sid mask flags>. The missing cell is the mask field (typically 0x0 for exact SID match).

Reproduce locally:
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) CHECK_DTBS=y qcom/shikra-cqm-evk.dtb
❌ check-patch-compliance

Root cause: All 4 commits use the PENDING: subject prefix, which does not comply with the required prefixes for upstream-bound patches.

Failure details:
Checking commit: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display
Commit summary does not start with a required prefix
Fix: Replace PENDING: with the appropriate prefix based on upstream status:

If patches are already merged upstream: use UPSTREAM: prefix

If patches are posted to mailing list but not yet merged: use FROMLIST: prefix

If patches are Qualcomm-internal only: use QCOM: prefix (if targeting qcom-next/qcom-next-staging)

For example:
FROMLIST: arm64: dts: qcom: shikra: Add MDSS display subsystem
Reproduce locally:
cd /path/to/kernel
git log --oneline acc3e66cc378..039d699c585c
# Verify each commit subject starts with UPSTREAM:, FROMLIST:, or QCOM:
Verdict

2 blockers must be fixed before merge:

dtb-check failure: Add missing SMMU mask cell (0x0) to the iommus property in shikra.dtsi

check-patch-compliance failure: Replace PENDING: prefix with UPSTREAM:, FROMLIST:, or QCOM: based on upstream status

After fixing these issues, re-run the kernel-checker CI to verify all checks pass.

qcomlnxci · 2026-06-22T06:07:37Z

Test jobs on 039d699

qcomlnxci · 2026-06-22T06:07:37Z

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
DSP_AudioPD	✅ Pass	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	◻️	◻️
Ethernet	⚠️ skip	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	◻️	◻️
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
GIC	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
IPA	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
Interrupts	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
OpenCV	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
PCIe	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️	◻️
RMNET	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
USBHost	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️	◻️
WiFi_Firmware_Driver	❌ Fail	❌ Fail	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
WiFi_OnOff	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	✅ Pass	◻️	◻️
hotplug	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
irq	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
kaslr	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
pinctrl	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
rngtest	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
shmbridge	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
smmu	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	◻️	◻️
watchdog	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️
wpss_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	◻️

Nabige Aala and others added 4 commits June 21, 2026 18:55

PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

3404948

Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module, used on the Shikra CQM EVK board. Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>

PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

039d699

Enable the DLC0697 MIPI DSI display panel on the Shikra CQS EVK. Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>

naala-qcom requested review from a team, Komal-Bajaj, aiquny and trsoni June 21, 2026 13:30

quicmahap approved these changes Jun 22, 2026

View reviewed changes

Conversation

naala-qcom commented Jun 21, 2026

Uh oh!

qlijarvis commented Jun 21, 2026

PR #749 — validate-patch

Final Summary

🔍 Patch Validation

Commit 1/4: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem

Commit Message

Diff

Commit 2/4: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel

Commit Message

Diff

Commit 3/4: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

Commit Message

Diff

Commit 4/4: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

Commit Message

Diff

Issues

Verdict

Final Summary

Uh oh!

qlijarvis commented Jun 21, 2026

PR #749 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ dtb-check

❌ check-patch-compliance

Verdict

Uh oh!

qcomlnxci commented Jun 22, 2026

Test jobs on 039d699

Uh oh!

qcomlnxci commented Jun 22, 2026

Test Matrix

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants