Require C++17 consistently#725
Merged
Merged
Conversation
3 tasks
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README already lists a C++17-compatible compiler as a prerequisite, but the build system did not actually enforce this in a consistent way.
Changes:
CMAKE_CXX_STANDARD_REQUIRED=ONto fail fast instead of silently degrading to a lower version.target_compile_featureson the library target fromcxx_std_11tocxx_std_17for consistency.HAVE_CXX17cmake option and usages in the code.Unrelated to those changes, I have bumped the minimum CMake version to 3.12 for consistency with FindODBC, which was added in that version.