move jdt.ls.vmargs before "-jar" in order to work#88
Merged
Conversation
gorkem
suggested changes
Nov 3, 2016
gorkem
left a comment
gorkem
left a comment
Contributor
There was a problem hiding this comment.
Good catch! The changes look good but I see that the commit refers to a submodule for path vscode-java, can you please remove it?
Contributor
Author
|
meh, not sure how this submodule got here, anyway now it's removed. |
Collaborator
|
Thanks for the fix @jpospychala , the JLS starts much faster when |
Contributor
Author
|
you welcome :-) On Thu, Nov 3, 2016 at 1:47 PM, Fred Bricon notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi,
jdt.ls.vmargs preference doesn't work now. I think it's because it is added added AFTER "-jar" argument, so extra args land as JAR arguments, instead of JVM arguments.