Refactor module functions with begin/process/end and harden module maintenance flow by Copilot · Pull Request #46 · rwidmark/MaintainModule

Copilot · 2026-04-16T17:54:30Z

This updates the module functions to use PowerShell begin/process/end execution blocks and tightens error handling around repository and module operations. It also simplifies the maintenance flow so update, install-missing, and old-version cleanup behave more consistently.

Execution flow
- Refactored exported functions to use begin/process/end where pipeline-aware behavior makes sense.
- Added a small internal helper to normalize installed module metadata before update/uninstall decisions.
Error handling
- Added targeted try/catch around Get-InstalledModule, Find-Module, Update-Module, Install-Module, Uninstall-Module, and PSGallery trust configuration.
- Switched failure points to explicit -ErrorAction Stop where recovery or reporting is required.
Control-flow cleanup
- Separated installed-module discovery from missing-module tracking so Update-rsModule can reliably handle both.
- Fixed old-version cleanup so uninstall decisions are based on a single collected version set instead of repeated ad hoc calls.
- Improved ShouldProcess usage for update, install, uninstall, and PSGallery trust changes.
Optimization
- Reduced repeated module/version processing by centralizing version selection and module detail shaping.
- Normalized version sorting/comparison through parsed version values rather than repeated inline conversions.
Operational messaging
- Tightened status/warning output to better distinguish:
  - no installed modules found
  - requested modules not installed
  - repository versions unavailable for a module

Example of the refactored pattern used across functions:

begin {
    $requestedModules = [System.Collections.Generic.List[string]]::new()
}

process {
    foreach ($moduleName in @($Module)) {
        if (-not [string]::IsNullOrWhiteSpace($moduleName)) {
            [void]$requestedModules.Add($moduleName)
        }
    }
}

end {
    $modulesToProcess = if ($requestedModules.Count -gt 0) { $requestedModules.ToArray() } else { $null }
    $getModuleInfo = Get-rsInstalledModule -Module $modulesToProcess
}

Agent-Logs-Url: https://github.com/rwidmark/MaintainModule/sessions/110e489a-bc1a-4e49-9063-b756ca88703f Co-authored-by: rwidmark <76907327+rwidmark@users.noreply.github.com>

Copilot

Pull request overview

Refactors the MaintainModule PowerShell module to be more pipeline-aware (via begin/process/end) while hardening repository/module maintenance operations with more explicit error handling and consolidated module/version shaping.

Changes:

Introduces an internal helper (Get-rsModuleDetail) to normalize installed module metadata and version selection.
Refactors exported functions to use begin/process/end blocks and improves ShouldProcess usage around update/install/uninstall and PSGallery trust changes.
Centralizes version parsing/sorting to reduce repeated module/version processing during maintenance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-16T17:59:04Z

+        foreach ($currentModule in @($Module)) {
+            if ([string]::IsNullOrWhiteSpace($currentModule)) {
+                continue
+            }
+
+            Write-Output "START - Uninstall older versions of $currentModule"
+            Write-Output "Please wait, this can take some time..."
+
+            foreach ($_version in $versionsToRemove) {


Uninstall-rsModule currently becomes a no-op when -Module is omitted (the process loop only iterates over provided module names and there is no fallback path). This conflicts with the help text/examples that imply omitting -Module uninstalls old versions for all installed modules. Either implement the all-modules behavior (e.g., discover installed modules + old versions and loop them) or make -Module mandatory and update the comment-based help accordingly.

Suggested change

foreach ($currentModule in @($Module)) {

if ([string]::IsNullOrWhiteSpace($currentModule)) {

continue

}

Write-Output "START - Uninstall older versions of $currentModule"

Write-Output "Please wait, this can take some time..."

foreach ($_version in $versionsToRemove) {

$modulesToProcess = @($Module | Where-Object { -not [string]::IsNullOrWhiteSpace($_) })

if ($modulesToProcess.Count -eq 0) {

try {

$modulesToProcess = @(Get-InstalledModule -AllVersions -ErrorAction Stop | Select-Object -ExpandProperty Name -Unique)

}

catch {

Write-Error "Failed to discover installed modules. $($PSItem.Exception.Message)"

return

}

}

foreach ($currentModule in $modulesToProcess) {

Write-Output "START - Uninstall older versions of $currentModule"

Write-Output "Please wait, this can take some time..."

try {

$installedVersions = @(Get-InstalledModule -Name $currentModule -AllVersions -ErrorAction Stop | Sort-Object Version -Descending)

}

catch {

Write-Error "Failed to get installed versions for $($currentModule). $($PSItem.Exception.Message)"

continue

}

if ($versionsToRemove.Count -gt 0) {

$moduleVersionsToRemove = @(

$installedVersions |

Where-Object { $versionsToRemove -contains $_.Version } |

ForEach-Object { $_.Version }

)

}

else {

$moduleVersionsToRemove = @(

$installedVersions |

Select-Object -Skip 1 |

ForEach-Object { $_.Version }

)

}

if ($moduleVersionsToRemove.Count -eq 0) {

Write-Output "FINISHED - No older versions of $currentModule were found to uninstall."

continue

}

foreach ($_version in $moduleVersionsToRemove) {

Copilot · 2026-04-16T17:59:05Z

+                        ErrorAction = 'Stop'
                    }
-                    Write-Output "$($_module.Name) has now been updated to version $($CollectLatestVersion)!"



Update-rsModule uses Find-Module results to decide whether an update is required, but it does not pass -AllowPrerelease when $AllowPrerelease is $true. This can cause prerelease updates to be skipped because the version comparison is based only on stable versions. Consider adding AllowPrerelease = $AllowPrerelease to $findModuleParameters when enabled so discovery and update behavior stay consistent.

Suggested change

if ($AllowPrerelease) {

$findModuleParameters.AllowPrerelease = $AllowPrerelease

}

Copilot AI and others added 7 commits April 16, 2026 17:42

Refactor module execution flow

04e73ae

Agent-Logs-Url: https://github.com/rwidmark/MaintainModule/sessions/110e489a-bc1a-4e49-9063-b756ca88703f Co-authored-by: rwidmark <76907327+rwidmark@users.noreply.github.com>

Address review feedback

4e25113

Agent-Logs-Url: https://github.com/rwidmark/MaintainModule/sessions/110e489a-bc1a-4e49-9063-b756ca88703f Co-authored-by: rwidmark <76907327+rwidmark@users.noreply.github.com>

Polish module messaging

ab70b3b

Agent-Logs-Url: https://github.com/rwidmark/MaintainModule/sessions/110e489a-bc1a-4e49-9063-b756ca88703f Co-authored-by: rwidmark <76907327+rwidmark@users.noreply.github.com>

Clarify module status messages

543cc3e

Agent-Logs-Url: https://github.com/rwidmark/MaintainModule/sessions/110e489a-bc1a-4e49-9063-b756ca88703f Co-authored-by: rwidmark <76907327+rwidmark@users.noreply.github.com>

Tighten module version handling

95b45c3

Agent-Logs-Url: https://github.com/rwidmark/MaintainModule/sessions/110e489a-bc1a-4e49-9063-b756ca88703f Co-authored-by: rwidmark <76907327+rwidmark@users.noreply.github.com>

Simplify module guards

b24609c

Agent-Logs-Url: https://github.com/rwidmark/MaintainModule/sessions/110e489a-bc1a-4e49-9063-b756ca88703f Co-authored-by: rwidmark <76907327+rwidmark@users.noreply.github.com>

Normalize version sorting

b54c781

Agent-Logs-Url: https://github.com/rwidmark/MaintainModule/sessions/110e489a-bc1a-4e49-9063-b756ca88703f Co-authored-by: rwidmark <76907327+rwidmark@users.noreply.github.com>

Copilot AI assigned Copilot and rwidmark Apr 16, 2026

Copilot created this pull request from a session on behalf of rwidmark April 16, 2026 17:54 View session

rwidmark requested a review from Copilot April 16, 2026 17:55

Copilot started reviewing on behalf of rwidmark April 16, 2026 17:55 View session

rwidmark marked this pull request as ready for review April 16, 2026 17:56

Copilot AI reviewed Apr 16, 2026

View reviewed changes

rwidmark merged commit a300375 into dev Apr 16, 2026
4 checks passed

rwidmark deleted the copilot/add-begin-process-end-blocks branch April 16, 2026 18:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor module functions with begin/process/end and harden module maintenance flow#46

Refactor module functions with begin/process/end and harden module maintenance flow#46
rwidmark merged 7 commits into
devfrom
copilot/add-begin-process-end-blocks

Copilot AI commented Apr 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-        foreach ($currentModule in @($Module)) {
-            if ([string]::IsNullOrWhiteSpace($currentModule)) {
-                continue
-            }
-            Write-Output "START - Uninstall older versions of $currentModule"
-            Write-Output "Please wait, this can take some time..."
-            foreach ($_version in $versionsToRemove) {
+        $modulesToProcess = @($Module | Where-Object { -not [string]::IsNullOrWhiteSpace($_) })
+        if ($modulesToProcess.Count -eq 0) {
+            try {
+                $modulesToProcess = @(Get-InstalledModule -AllVersions -ErrorAction Stop | Select-Object -ExpandProperty Name -Unique)
+            }
+            catch {
+                Write-Error "Failed to discover installed modules. $($PSItem.Exception.Message)"
+                return
+            }
+        }
+        foreach ($currentModule in $modulesToProcess) {
+            Write-Output "START - Uninstall older versions of $currentModule"
+            Write-Output "Please wait, this can take some time..."
+            try {
+                $installedVersions = @(Get-InstalledModule -Name $currentModule -AllVersions -ErrorAction Stop | Sort-Object Version -Descending)
+            }
+            catch {
+                Write-Error "Failed to get installed versions for $($currentModule). $($PSItem.Exception.Message)"
+                continue
+            }
+            if ($versionsToRemove.Count -gt 0) {
+                $moduleVersionsToRemove = @(
+                    $installedVersions |
+                    Where-Object { $versionsToRemove -contains $_.Version } |
+                    ForEach-Object { $_.Version }
+                )
+            }
+            else {
+                $moduleVersionsToRemove = @(
+                    $installedVersions |
+                    Select-Object -Skip 1 |
+                    ForEach-Object { $_.Version }
+                )
+            }
+            if ($moduleVersionsToRemove.Count -eq 0) {
+                Write-Output "FINISHED - No older versions of $currentModule were found to uninstall."
+                continue
+            }
+            foreach ($_version in $moduleVersionsToRemove) {

+                    if ($AllowPrerelease) {
+                        $findModuleParameters.AllowPrerelease = $AllowPrerelease
+                    }

Conversation

Copilot AI commented Apr 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants