ENH Newton-CD part 1: add gap_smaller_eps to CD solvers#34285
Merged
OmarManzoor merged 3 commits intoJun 19, 2026
Conversation
Member
Author
|
@OmarManzoor @virchan This is a first small PR towards #33160. It is about the dual gap so you are already familiar with that code. |
OmarManzoor
reviewed
Jun 18, 2026
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR @lorentzenchr
github-actions
Bot
added
the
CI:Linter failure
github-actions
Bot
removed
the
CI:Linter failure
OmarManzoor
approved these changes
Jun 19, 2026
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you @lorentzenchr
Member
Author
|
@OmarManzoor Thanks for you review. This PR has no user impact, minor improvement. Can we merge already? |
Contributor
Yes sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part 1 of #33160.
What does this implement/fix? Explain your changes.
This PR adda
gap_smaller_epsto the dual gap computation, which sets the dual gap to zero in case it is smaller thangap_smaller_eps.This has no user impact, the current behavior is kept (functionality only for future purposes).
AI usage disclosure
None
Any other comments?