Skip to content

DOC small docstring improvements to LogisticRegression#34288

Merged
OmarManzoor merged 7 commits into
scikit-learn:mainfrom
lorentzenchr:lr_docstring
Jun 18, 2026
Merged

DOC small docstring improvements to LogisticRegression#34288
OmarManzoor merged 7 commits into
scikit-learn:mainfrom
lorentzenchr:lr_docstring

Conversation

@lorentzenchr

Copy link
Copy Markdown
Member

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

Small docstring improvements of LogisticRegression, in particular moving the references of the solvers to the user guide.

AI usage disclosure

I used AI assistance for:

  • Research and understanding

@virchan virchan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @lorentzenchr!

Comment thread doc/modules/linear_model.rst Outdated
@virchan virchan added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! labels Jun 15, 2026
@github-actions github-actions Bot added the CI:Linter failure The linter CI is failing on this PR label Jun 15, 2026
Comment thread doc/modules/linear_model.rst Outdated
@virchan

virchan commented Jun 15, 2026

Copy link
Copy Markdown
Member

FYI: I don't think the CI failure is caused by this PR. I've opened #34292 to track it.

@shipitdev shipitdev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left a few minor formatting nits inline once these are resolved, this is good to go !
Thank you for contributing :)

Comment thread doc/modules/linear_model.rst
Comment thread sklearn/linear_model/_logistic.py Outdated
@github-actions github-actions Bot removed the CI:Linter failure The linter CI is failing on this PR label Jun 17, 2026

@OmarManzoor OmarManzoor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @lorentzenchr

Comment thread doc/modules/linear_model.rst Outdated
@OmarManzoor OmarManzoor removed the Waiting for Second Reviewer First reviewer is done, need a second one! label Jun 18, 2026
Co-authored-by: Omar Salman <omar.salman2007@gmail.com>
@OmarManzoor OmarManzoor enabled auto-merge (squash) June 18, 2026 09:18
@OmarManzoor OmarManzoor merged commit ae60c15 into scikit-learn:main Jun 18, 2026
36 checks passed
@lorentzenchr lorentzenchr deleted the lr_docstring branch June 18, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants