BLD: install missing .pxd files, and update TODOs/FIXMEs in meson.build files#16749
Merged
Conversation
This is no longer necessary, the PR linked in the removed comment is included in our `highs` git submodule now.
This was fixed I believe (there are no skipped or xfailed tests either), and the comment isn't very informative.
…broken The code can be simplified once the upstream feature is added, but that's not a FIXME.
We can rely on C++14 unconditionally since 2021, see http://scipy.github.io/devdocs/dev/toolchain.html#c-language-standards
No tests were failing, so something is fairly badly wrong in the test suite. Also add `optimize.cython_optimize` to the list of submodules that are public API.
This was fixed when adding `--git-dir` to the git invocation, that made the result independent from the current directory when invoking the build.
This flag is added implicitly via 'fortran_std=legacy' in the top-level `meson.build`. Warnings that show up are silenced in multiple modules, so there's no need for a separate TODO here.
This isn't a very useful today, given that we don't use this version string. The corresponding `setup.py` file also does the same and doesn't have a TODO.
rgommers
added
maintenance
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Aug 25, 2022
…uild files (scipy#16749) * BLD: remove a warning suppression flag for HiGHS extension This is no longer necessary, the PR linked in the removed comment is included in our `highs` git submodule now. * BLD: remove an outdated FIXME from the scipy/integrate/meson.build This was fixed I believe (there are no skipped or xfailed tests either), and the comment isn't very informative. * BLD: remove another FIXME in `cython_optimize/meson.build`, it's not broken The code can be simplified once the upstream feature is added, but that's not a FIXME. * BLD: remove comments about c++14/c++11 support We can rely on C++14 unconditionally since 2021, see http://scipy.github.io/devdocs/dev/toolchain.html#c-language-standards * BLD: update info on including all license files as separate files * BLD: install missing `scipy/*.pxd` files No tests were failing, so something is fairly badly wrong in the test suite. Also add `optimize.cython_optimize` to the list of submodules that are public API. * BLD: remove FIXME about version string generation This was fixed when adding `--git-dir` to the git invocation, that made the result independent from the current directory when invoking the build. * BLD: remove TODO about `-fallow-argument-mismatch` This flag is added implicitly via 'fortran_std=legacy' in the top-level `meson.build`. Warnings that show up are silenced in multiple modules, so there's no need for a separate TODO here. * BLD: remove TODO for UNU.RAN version string This isn't a very useful today, given that we don't use this version string. The corresponding `setup.py` file also does the same and doesn't have a TODO. * BLD: update FIXME to a TODO in `linalg/meson.build`
tylerjereddy
removed
the
backport-candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing
.pxdfiles are a pretty serious bug. Somehow no one noticed this, due to a combination of no tests (see gh-16748 for that task) and the nightlies not having been generated for a while until recently. The relevant commit should be backported to1.9.x.There were also a number of open FIXME and TODO comments that were either actionable, already fixed, or no longer relevant. There are no FIXME's left, and the remaining TODO's mostly have to do with 64-bit BLAS/LAPACK support: