Skip to content

Update grunt-contrib-qunit to latest version#5530

Merged
kevin-brown merged 1 commit into
developfrom
update-grunt-qunit
Jun 5, 2019
Merged

Update grunt-contrib-qunit to latest version#5530
kevin-brown merged 1 commit into
developfrom
update-grunt-qunit

Conversation

@kevin-brown

Copy link
Copy Markdown
Member

This pull request includes a

  • Bug fix
  • New feature
  • Translation
  • Dependency update

The following changes were made

  • Updated grunt-contrib-qunit to the latest version

We needed to define the `qunit` module in the unit tests because there was a change in grunt-contrib-qunit 0.6.0 that breaks when you define an AMD loader. It expects that the AMD loader is also used to load QUnit, instead of just being used to support the tests, so if you don't define the qunit module it will just hang and do nothing. Luckily we have the helpers file to help us out here, since it allows us to globally define this module.
@kevin-brown kevin-brown merged commit 5d2fdd7 into develop Jun 5, 2019
@kevin-brown kevin-brown deleted the update-grunt-qunit branch June 5, 2019 02:43
@kevin-brown kevin-brown added this to the 4.0.8 milestone Jun 5, 2019
maxwellfet928 pushed a commit to maxwellfet928/select2 that referenced this pull request Jun 8, 2026
We needed to define the `qunit` module in the unit tests because there was a change in grunt-contrib-qunit 0.6.0 that breaks when you define an AMD loader. It expects that the AMD loader is also used to load QUnit, instead of just being used to support the tests, so if you don't define the qunit module it will just hang and do nothing. Luckily we have the helpers file to help us out here, since it allows us to globally define this module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant