Skip to content

Make TypeError messages contain type name instead of a repr.#191

Merged
etrepum merged 2 commits into
masterfrom
type-error-messages
Nov 23, 2017
Merged

Make TypeError messages contain type name instead of a repr.#191
etrepum merged 2 commits into
masterfrom
type-error-messages

Conversation

@serhiy-storchaka

Copy link
Copy Markdown
Contributor

The failure depends on the type, not on the value of an object.

This combines CPython's issues 26623 and 24641.

The failure depends on the type, not on the value of an object.

This combines CPython's issues 26623 and 24641.

@etrepum etrepum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively good but it would be nice to have some test coverage

@etrepum etrepum merged commit 9127262 into master Nov 23, 2017
@serhiy-storchaka serhiy-storchaka deleted the type-error-messages branch November 27, 2017 06:29
clrpackages pushed a commit to clearlinux-pkgs/simplejson that referenced this pull request Nov 27, 2017
…on 3.13.2

Bob Ippolito (21):
      Add Python 3.6.3 to appveyor
      Merge pull request #188 from simplejson/bpo-31505
      added editorconfig
      update artifacts.py to avoid none-any wheels
      v3.12.1
      Workarounds for NamedTemporaryFile issues with Windows for tool tests
      Update version, add *.pyd to gitignore
      update appveyor config
      Merge pull request #191 from simplejson/type-error-messages
      update CHANGES
      Ensure that encoding text subtypes is consistent with or without speedups. Fixes #185
      Fix string encoding for Python 2
      fix appveyor.yml
      fix artifact matching
      build sdist from travis
      also upload tarball
      Merge pull request #194 from simplejson/speedups-compile-error-2.7
      fail build in CI if speedups do not build correctly
      v3.13.1
      maybe fix windows 2.x build
      v3.13.2

Serhiy Storchaka (7):
      bpo-31505: Fix an assertion failure in json, in case _json.make_encoder() received a bad encoder() argument. Original patch by Oren Milman.
      Fix a test.
      Fix a reference leak when sort keys. (#186)
      bpo-31095: fix potential crash during GC (#187)
      Make TypeError messages contain type name instead of a repr. The failure depends on the type, not on the value of an object.
      Add tests.
      Fix a compile error on 2.x. Closes #193.

Version 3.13.2 released 2017-11-24

* Fix additional Python 2.x compilation issue on Windows

Version 3.13.1 released 2017-11-24

* Improve CI to catch speedups build regressions
* Fix speedups build regression in Python 2.x
  simplejson/simplejson#193

Version 3.13.0 released 2017-11-23

* Workarounds for NamedTemporaryFile issues with Windows for tool tests
* Make TypeError messages contain type name instead of a repr.
  simplejson/simplejson#191

(NEWS truncated at 15 lines)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants