Skip to content

group: add an explicit assertion for too many entities #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phkahler merged 1 commit into from
Aug 10, 2025
Merged

group: add an explicit assertion for too many entities #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/group.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,6 +862,11 @@ void Group::GenerateEquations(IdList<Equation,hEquation> *l) {
hEntity Group::Remap(hEntity in, int copyNumber) {
auto it = remap.find({ in, copyNumber });
if(it == remap.end()) {
// Due to the way the remap value is combined with the group handle into a 32-bit
// handle value to generate an entity handle, the mapped value must fit in a 16-bit
// variable.
// This limit can be lifted once the handle values are extended to 64-bit.
ssassert(remap.size() < (1 << 16) - 1, "Too many entities in group");
std::tie(it, std::ignore) =
remap.insert({ { in, copyNumber }, { (uint32_t)remap.size() + 1 } });
}
Expand Down
2 changes: 1 addition & 1 deletion src/sketch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ struct IsHandleOracle<EntityId> : std::true_type {};
struct EntityKey {
hEntity input;
int copyNumber;
// (input, copyNumber) gets mapped to ((Request)xxx).entity(h.v)
// (input, copyNumber) gets mapped to hGroup::entity(i)
};
struct EntityKeyHash {
size_t operator()(const EntityKey &k) const {
Expand Down