Add missing file extension on sketch save#1724
Open
wolfpackmars2 wants to merge 2 commits into
Open
Conversation
…ified This fix should append .slvs to sketch files, regardless of the UI used. If a different file extension exists, it will be retained and .slvs will not be added. Resolves solvespace#1689
Contributor
Author
|
I realized that changing the filename outside of the usual GUI mechanisms could introduce filename conflicts, so the new commit fixes that. It's no secret that I am working with Codex, but the code, and the oversight, are mine. To apologize for my oversight, I added some tests for my changes since it was recently mentioned that test coverage could be improved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix should append .slvs to sketch files, regardless of the UI used, if no file extension was given.
If a different file extension exists, it will be retained and .slvs will not be added.
Resolves #1689
Tested in Ubuntu Noble for Qt and GTK interfaces. That is, it fixes the Qt problem and doesn't break the GTK interface.