Skip to content

full refactor#129

Merged
mredolatti merged 41 commits into
developmentfrom
full_refactor
Apr 24, 2019
Merged

full refactor#129
mredolatti merged 41 commits into
developmentfrom
full_refactor

Conversation

@mredolatti

Copy link
Copy Markdown
Contributor

Python SDK

Tickets covered:

  • BUR Refactor
  • Impressions not flushing on destroy.

What did you accomplish?

  • Refactored whole SDK except for input validation & client.getTreatment/s base methods
  • Rewrote unit test suite using a more modern framework with python3 support

How to test new changes?

  • python setup.py test

@mmelograno mmelograno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work!!

@mredolatti mredolatti changed the base branch from master to development April 17, 2019 18:32
@mredolatti mredolatti merged commit 8b08be6 into development Apr 24, 2019
@mmelograno mmelograno deleted the full_refactor branch October 16, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants