Skip to content

Fix travis#10

Merged
jovial merged 5 commits into
masterfrom
fix/travis
Jun 8, 2020
Merged

Fix travis#10
jovial merged 5 commits into
masterfrom
fix/travis

Conversation

@jovial

@jovial jovial commented Jun 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Needed to specify pyflakes version early for:

    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/flake8/engine.py", line 172, in _retry_serial
    return func(*args, **kwargs)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pep8.py", line 1670, in check_files
    self.input_dir(path)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pep8.py", line 1706, in input_dir
    runner(os.path.join(root, filename))
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/flake8/engine.py", line 126, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pep8.py", line 1412, in check_all
    self.check_ast()
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pep8.py", line 1358, in check_ast
    checker = cls(tree, self.filename)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/flake8/_pyflakes.py", line 61, in __init__
    super(FlakesChecker, self).__init__(tree, filename,
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 294, in __init__
    self.handleChildren(tree)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 547, in handleChildren
    self.handleNode(node, tree)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 589, in handleNode
    handler(node)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 547, in handleChildren
    self.handleNode(node, tree)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 589, in handleNode
    handler(node)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 547, in handleChildren
    self.handleNode(node, tree)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 589, in handleNode
    handler(node)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 547, in handleChildren
    self.handleNode(node, tree)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 588, in handleNode
    handler = self.getNodeHandler(node.__class__)
  File "/home/will/code/stackhpc-inspector-plugins/.tox/pep8/lib/python3.8/site-packages/pyflakes/checker.py", line 458, in getNodeHandler
    self._nodeHandlers[node_class] = handler = getattr(self, nodeType)
AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'

See: PyCQA/pyflakes#367

needed ironic client for:

ImportError: Failed to import test module: stackhpc_inspector_plugins.tests.unit.test_plugins_system_name_physnet
Traceback (most recent call last):
  File "/usr/lib/python3.8/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.8/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/will/code/stackhpc-inspector-plugins/stackhpc_inspector_plugins/tests/unit/test_plugins_system_name_physnet.py", line 22, in <module>
    from stackhpc_inspector_plugins.plugins import system_name_physnet
  File "/home/will/code/stackhpc-inspector-plugins/stackhpc_inspector_plugins/plugins/system_name_physnet.py", line 20, in <module>
    from stackhpc_inspector_plugins.plugins import base_physnet
  File "/home/will/code/stackhpc-inspector-plugins/stackhpc_inspector_plugins/plugins/base_physnet.py", line 21, in <module>
    from ironicclient import exc as client_exc
ModuleNotFoundError: No module named 'ironicclient'

markgoddard and others added 2 commits February 7, 2020 15:11
@markgoddard
Use py3 for tox by default, use train UC for python <= 3.5
fc51347 
Upstream OpenStack has dropped support for python 2, and even python
3.5. This means that master upper constraints no longer install on these
versions.
@jovial
Test with python 3.8
5e5ceaf
@jovial jovial requested a review from markgoddard June 5, 2020 16:45
@jovial jovial mentioned this pull request Jun 5, 2020
Closed
@markgoddard

markgoddard commented Jun 8, 2020

Copy link
Copy Markdown

Why py3.8? 3.8 isn't a supported runtime for OpenStack until Victoria. Train and Ussuri support 3.6-3.7.

@jovial

jovial commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

OK, add a job for 3.7 and 3.6 then?

@markgoddard

markgoddard commented Jun 8, 2020

Copy link
Copy Markdown

OK, add a job for 3.7 and 3.6 then?

+1

@jovial
Test with python3.6 and python3.7
1a85fdb 
3.8 isn't a supported runtime for OpenStack until Victoria. Train and Ussuri support 3.6-3.7.
@jovial jovial changed the title Test with python 3.8 Fix travis Jun 8, 2020
@jovial jovial changed the base branch from py2-dropped-upstream to master June 8, 2020 13:39
@jovial jovial merged commit 20abc82 into master Jun 8, 2020
@jovial jovial deleted the fix/travis branch June 8, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@markgoddard markgoddard markgoddard approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jovial @markgoddard