Skip to content

SDK migration Secrets-Manager#1454

Merged
SerseusWasTaken merged 2 commits into
mainfrom
chore/secretsmanager-new-sdk
Jul 2, 2026
Merged

SDK migration Secrets-Manager#1454
SerseusWasTaken merged 2 commits into
mainfrom
chore/secretsmanager-new-sdk

Conversation

@SerseusWasTaken

@SerseusWasTaken SerseusWasTaken commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Updates the Secrets-Manager SDK

relates to STACKITCLI-377

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken SerseusWasTaken requested a review from a team as a code owner July 2, 2026 11:10
@SerseusWasTaken SerseusWasTaken force-pushed the chore/secretsmanager-new-sdk branch from e95c65b to 6cdbd45 Compare July 2, 2026 11:29
@SerseusWasTaken SerseusWasTaken force-pushed the chore/secretsmanager-new-sdk branch from 6cdbd45 to c9aee40 Compare July 2, 2026 11:35
cgoetz-inovex
cgoetz-inovex previously approved these changes Jul 2, 2026
View reviewed changes
Comment thread internal/cmd/secrets-manager/instance/list/list.go Outdated
Comment thread internal/cmd/secrets-manager/instance/update/update.go Outdated
Comment thread internal/cmd/secrets-manager/instance/update/update.go Outdated
Comment thread internal/cmd/secrets-manager/instance/update/update_test.go Outdated
Comment thread internal/cmd/secrets-manager/user/create/create.go Outdated
Comment thread internal/cmd/secrets-manager/user/list/list.go Outdated
Comment thread internal/pkg/services/secrets-manager/utils/utils.go
Comment thread internal/pkg/services/secrets-manager/utils/utils_test.go Outdated
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (2 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/create 57.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/delete 34.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/describe 66.18% (-0.49%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/list 52.17% (+1.11%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/update 50.77% (-0.05%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/create 56.52% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/delete 37.50% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/describe 61.36% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/list 55.10% (+1.10%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/update 54.24% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/secrets-manager/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/secrets-manager/utils 100.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/create/create.go 57.38% (ø) 61 35 26
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/delete/delete.go 34.38% (ø) 32 11 21
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/describe/describe.go 66.18% (-0.49%) 68 (-1) 45 (-1) 23 👎
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/list/list.go 52.17% (+1.11%) 46 (-1) 24 22 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/update/update.go 50.77% (-0.05%) 65 (+4) 33 (+2) 32 (+2) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/create/create.go 56.52% (ø) 46 26 20
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/delete/delete.go 37.50% (ø) 40 15 25
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/describe/describe.go 61.36% (ø) 44 27 17
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/list/list.go 55.10% (+1.10%) 49 (-1) 27 22 (-1) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/update/update.go 54.24% (ø) 59 32 27
github.com/stackitcloud/stackit-cli/internal/pkg/services/secrets-manager/client/client.go 0.00% (ø) 1 0 1
github.com/stackitcloud/stackit-cli/internal/pkg/services/secrets-manager/utils/utils.go 100.00% (ø) 14 14 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/user/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/secrets-manager/utils/utils_test.go

@SerseusWasTaken SerseusWasTaken merged commit 49c9394 into main Jul 2, 2026
3 checks passed
@SerseusWasTaken SerseusWasTaken deleted the chore/secretsmanager-new-sdk branch July 2, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgoetz-inovex cgoetz-inovex cgoetz-inovex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SerseusWasTaken @cgoetz-inovex