Skip to content

fix: set gcp iam binding --condition=None#21140

Merged
jschnath merged 1 commit into
release-4.9from
4.9/fix-iam-policy-condition
Jun 15, 2026
Merged

fix: set gcp iam binding --condition=None#21140
jschnath merged 1 commit into
release-4.9from
4.9/fix-iam-policy-condition

Conversation

@stehessel

@stehessel stehessel commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR fixes a gcloud issue that got introduced by setting a creation date meta condition on master. Unfortunately this had unforeseen consequences for release branches that causes ocp qa tests to fail. The easiest fix is set --condition=None explicitly to make the release branch forward compatible. See #21136 for more context.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 03acb19f-c19f-43b8-b2f8-a4530f2173d1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 4.9/fix-iam-policy-condition

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the backport PR to backport changes from master to release branch label Jun 15, 2026
@stehessel

stehessel commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

/test ocp-4-21-qa-e2e-tests ocp-4-22-qa-e2e-tests

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest main-on-push

@rhacs-bot

rhacs-bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 847e06c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.8-rc.2-1-g847e06c9a7.

@codecov

codecov Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.88%. Comparing base (bbd7130) to head (847e06c).

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-4.9   #21140      +/-   ##
===============================================
- Coverage        48.88%   48.88%   -0.01%     
===============================================
  Files             2719     2719              
  Lines           202937   202937              
===============================================
- Hits             99215    99207       -8     
- Misses           95961    95967       +6     
- Partials          7761     7763       +2
Flag Coverage Δ
go-unit-tests 48.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stehessel stehessel requested a review from tommartensen June 15, 2026 14:51
@stehessel stehessel marked this pull request as ready for review June 15, 2026 14:51
@stehessel stehessel requested a review from janisz as a code owner June 15, 2026 14:51
@jschnath jschnath added this to the 4.9.8-rc.3 milestone Jun 15, 2026
@jschnath jschnath merged commit 4bf16c2 into release-4.9 Jun 15, 2026
101 of 117 checks passed
@jschnath jschnath deleted the 4.9/fix-iam-policy-condition branch June 15, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommartensen tommartensen tommartensen approved these changes

@janisz janisz Awaiting requested review from janisz janisz is a code owner

Assignees

No one assigned

Labels

backport PR to backport changes from master to release branch

Projects

None yet

Milestone

4.9.8-rc.3

Development

Successfully merging this pull request may close these issues.

4 participants

@stehessel @rhacs-bot @tommartensen @jschnath