Skip to content

fix calculation of subsecond conversion in MIX or BIN mode#102

Merged
fpistm merged 1 commit into
stm32duino:mainfrom
FRASTM:fix_mix_bcd
Oct 6, 2023
Merged

fix calculation of subsecond conversion in MIX or BIN mode#102
fpistm merged 1 commit into
stm32duino:mainfrom
FRASTM:fix_mix_bcd

Conversation

@FRASTM

@FRASTM FRASTM commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Depending on the RTC mode, the SSR subsecond register and AlarmSSR
differ when converted to/from a value in milliseconds
Correcting the formula in GetTime, GetAlarm/StartAlarm functions.
Update description (README) for BINary only mode use with getEpoch and setAlarmEpoch

@FRASTM FRASTM marked this pull request as ready for review September 29, 2023 16:17
@fpistm fpistm added enhancement New feature or request bug labels Oct 5, 2023
@fpistm fpistm added this to the 1.4.0 milestone Oct 5, 2023
@fpistm fpistm self-requested a review October 5, 2023 14:27
Comment thread src/rtc.c Outdated
Comment thread src/rtc.c Outdated
@FRASTM FRASTM force-pushed the fix_mix_bcd branch 2 times, most recently from 635d357 to 8d7d27c Compare October 6, 2023 06:50
@fpistm fpistm self-requested a review October 6, 2023 07:01
Depending on the RTC mode, the SSR subsecond register and AlarmSSR
differ when converted to/from a value in milliseconds
Correcting the formula in GetTime, GetAlarm/StartAlarm functions.
Clarify the use of getEpoch and setAlarmEpoch in BIN only mode.

Signed-off-by: Francois Ramu <francois.ramu@st.com>

@fpistm fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit 3ce53c4 into stm32duino:main Oct 6, 2023
@fpistm fpistm added bug 🐛 Something isn't working fix 🩹 Bug fix and removed bug bug 🐛 Something isn't working labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fix 🩹 Bug fix

Projects

Development

Successfully merging this pull request may close these issues.

2 participants