test: add tests for mergeDeep, tighten types#399
Merged
Conversation
- Add 14 unit tests covering shallow/deep merge, multiple sources,
array overwrite, null preservation, source immutability, and falsy values
- Tighten ObjectType from `{ [key: string]: any }` to `Record<string, unknown>`
- Change isObject param from `any` to `unknown`
- Replace recursive sources.shift() with iterative for-of loop
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gka
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mergeDeepcovering shallow/deep merge, multiple sources, array overwrite, null preservation, source immutability, falsy value handling, and deeply nested objectsObjectTypefrom{ [key: string]: any }toRecord<string, unknown>isObjectparameter type fromanytounknownsources.shift()with iterativefor-ofloop (avoids array mutation and repeated spread+recurse)Test plan
🤖 Generated with Claude Code