test: add unit tests for getEmptyFacets#401
Merged
Merged
Conversation
- Add 11 unit tests for getEmptyFacets covering no marks, single/dual dimension faceting, empty fx+fy combinations, automatic marks, empty data, missing channels, full coverage, and multi-mark scenarios - Remove TODO comment (now addressed) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getEmptyFacetscovering no marks, single/dual dimension faceting, empty fx+fy combinations, automatic marks, empty data, missing channels, full coverage, and multi-mark scenarios// TODO: write unit testscomment (now addressed)Test plan
🤖 Generated with Claude Code