Skip to content

Fix 10 low-effort svelte-check issues in src/lib#472

Merged
gka merged 2 commits into
mainfrom
codex/fix-sveltecheck-issues-1
Feb 21, 2026
Merged

Fix 10 low-effort svelte-check issues in src/lib#472
gka merged 2 commits into
mainfrom
codex/fix-sveltecheck-issues-1

Conversation

@gka

@gka gka commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes a batch of low-effort svelte-check errors across src/lib components.

Included Sub-Issues

What Changed

  • Added missing generic type argument in facet context typing.
  • Fixed nullable class default in BollingerX.
  • Tightened default datum typing in CellX, CellY, and Anchor.
  • Corrected DataRow type import source in LineX and LineY.
  • Adjusted Rect mark prop ordering/type expression to satisfy MarkType checking.
  • Corrected RawValue import sources and guarded scale function access in linear gradients.

Validation

  • Ran pnpm check after changes.
  • The overall check still reports unrelated existing errors in other files.
  • The 10 targeted files in this PR now report no diagnostics.

@netlify

netlify Bot commented Feb 21, 2026

Copy link
Copy Markdown

Deploy Preview for svelteplot ready!

Name Link
🔨 Latest commit cea04a9
🔍 Latest deploy log https://app.netlify.com/projects/svelteplot/deploys/6999a9ed51f3cd00089032c2
😎 Deploy Preview https://deploy-preview-472--svelteplot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown

📦 Preview package for this PR is published!

Version: 0.10.3-pr-472.0

Install it with:

npm install svelteplot@pr-472
# or install the specific version
npm install svelteplot@0.10.3-pr-472.0

@github-actions

Copy link
Copy Markdown

📦 Preview package for this PR is published!

Version: 0.10.3-pr-472.1

Install it with:

npm install svelteplot@pr-472
# or install the specific version
npm install svelteplot@0.10.3-pr-472.1

@gka gka merged commit f3cf716 into main Feb 21, 2026
9 checks passed
@gka gka deleted the codex/fix-sveltecheck-issues-1 branch February 21, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant