types: Fix svelte-check issues in Line.svelte#484
Merged
Conversation
- Use undefined instead of null in DEFAULTS for class/lineClass - Add explicit types to groupIndex() group/groups variables - Replace callWithProps with fluent d3 line<ScaledDataRecord>() API to fix generic type inference - Cast sphereLine() result to D3Line<ScaledDataRecord> - Add tension ?? 0 fallback to maybeCurve call - Add explicit ScaledDataRecord types to line generator lambdas - Type sphereLine projection as any, inner line/lines arrays explicitly - Add null fallback for outlineStrokeWidth resolveProp result - Remove duplicate textAnchor key from pick() call - Switch MarkerPath props from broad-typed args.xxx to options.xxx with proper casts - Fix null vs undefined for dInv, style, text, startOffset, textStyle props - Pass lineData[0].datum (not lineData[0]) to resolveProp for lineClass - Add missing required transform prop to MarkerPath Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-484
# or install the specific version
npm install svelteplot@0.10.3-pr-484.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #437
Summary
src/lib/marks/Line.svelte(26 errors → 0)callWithProps(line, [])with the fluentline<ScaledDataRecord>()API to fix generic type inferenceMarkerPathprops from broad-typedargs.xxxto properly-typedoptions.xxxwith correct castsdInv,style,text,startOffset,textStyleprops passed toMarkerPathgroupIndex()andsphereLine()Test plan
pnpm check— no errors inLine.sveltepnpm lint— passes (Prettier + ESLint)pnpm lint:types— no errors inLine.sveltepnpm test— all 666 tests pass🤖 Generated with Claude Code