types: fix remaining svelte-check issues (74 errors → 0)#493
Conversation
- AxisX/AxisY: use TickFormatFunction (3-arg) for tickFormat prop type - Frame: accept boolean fill/stroke, converting true to 'currentColor' - RectX/RectY: change generic from DataRecord to DataRow to allow raw value arrays - PlotOptions: make axisProps/axisOptions optional in fx/fy scale types - Tests: use Event instead of MouseEvent for onclick handler types - Tests: remove stale @ts-expect-error in customMark test - Routes/examples: fix Datasets import, string-vs-number props, null checks, GridX/GridY ticks→data prop, exampleImages typing, animate:slide→flip Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-493
# or install the specific version
npm install svelteplot@0.10.3-pr-493.0 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a77e2eb16e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-493
# or install the specific version
npm install svelteplot@0.10.3-pr-493.1 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-493
# or install the specific version
npm install svelteplot@0.10.3-pr-493.2 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-493
# or install the specific version
npm install svelteplot@0.10.3-pr-493.3 |
1 participant
Summary
tickFormatprop to useTickFormatFunction(3-arg signature withticksarray) instead of narrower inline function typesfill/strokenow acceptboolean | string;truemaps to'currentColor'DataRecordtoDataRowso raw value arrays (e.g.[1, 2, 3]) are accepted as data, matching runtime behavioraxisPropsandaxisOptionsoptional (?:) in thefx/fyfacet scale option typesonclickhandler type fromMouseEventtoEventto matchMarkEventHandlersignature; removed stale@ts-expect-errorin customMark testDatasetsimport (not exported),strokeWidth/opacitystring→number, null checks in+layout.svelte,GridX/GridYticks→dataprop,exampleImagestyping,animate:slide→animate:flipsvelte-checkin CI workflow from now onTest plan
pnpm check— 0 errors (was 74), 30 warnings (unchanged)pnpm test— 675 tests passing🤖 Generated with Claude Code
resolves #481