fix: replace new Array() with Array.from() pattern#503
Merged
Conversation
Replace all `new Array(n)` usages with `Array.from({ length: n })` to
satisfy the no-new-array oxlint rule. Fixes all 10 warnings.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new Array(n)usages withArray.from({ length: n })orArray.from({ length: n }, () => value)for.fill()casesno-new-arrayoxlint warnings across 7 filesFiles changed
src/lib/helpers/noise.ts— perlin noise array initsrc/lib/helpers/roundedRect.ts— border radius arraysrc/lib/marks/helpers/trail.ts— resampled defined arraysrc/lib/regression/polynomial.ts— coefficient arrays (2 occurrences)src/lib/transforms/density.ts— CDF arrays (2 occurrences)src/lib/transforms/map.ts— mapped values arraysrc/tests/barX.test.svelte.ts— test assertions (2 occurrences)Test plan
pnpm exec oxlint --type-aware— 0no-new-arraywarningspnpm test— all tests passpnpm check— 0 svelte-check errors🤖 Generated with Claude Code