fix(svelteplot): auto margins immune to ancestor CSS transform scale#571
Open
ljodea wants to merge 1 commit into
Open
fix(svelteplot): auto margins immune to ancestor CSS transform scale#571ljodea wants to merge 1 commit into
ljodea wants to merge 1 commit into
Conversation
…S scale Replace getBoundingClientRect() in axis auto-margin effects with measureSvgTextLayoutExtent(), which reads getBBox() and applies the tick text element's local SVG transform. This keeps margins in plot layout units when ancestor elements apply transform: scale(). Adds jsdom integration tests with mocked geometry inflation, browser regression tests (Vitest + Playwright) for scale-invariance, and CI wiring for test:browser. Fixes #179
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #179 by measuring axis tick labels in SVG user space instead of viewport pixels from
getBoundingClientRect().When a parent applies
transform: scale(), inflated margin measurements could feed a reactive loop between X/Y axis$effects until Svelte throwseffect_update_depth_exceeded. This PR replaces the viewport measurement withmeasureSvgTextLayoutExtent(), which:getBBox()on tick<text>elements (aggregating<tspan>children when needed)0on detached/hidden elements instead of propagating bad geometryTest plan
measureSvgTextLayoutExtent.test.ts) — T1–T4: unscaled vs inflated gbcr, rotation, error handlingCI
Adds
pnpm --filter svelteplot test:browserto.github/workflows/test.ymlwith Playwright chromium install.Codex review
Independent diff review: PASS — no [P1] or [P2] findings.