Many accounts per EOA#561
Merged
Merged
Conversation
joaquim-verges
approved these changes
Oct 28, 2023
joaquim-verges
left a comment
joaquim-verges
left a comment
Member
There was a problem hiding this comment.
LG, just that comment on the encode fn
|
|
||
| /// @dev Returns the salt used when deploying an Account. | ||
| function _generateSalt(address _admin, bytes memory _data) internal view virtual returns (bytes32) { | ||
| return keccak256(abi.encodePacked(_admin, _data)); |
Member
There was a problem hiding this comment.
I think we should use encode instead of encode packed here ? From what I read online it's better suited for dynamic types like bytes
| function _generateSalt(address _admin, bytes memory) internal view virtual returns (bytes32) { | ||
| return keccak256(abi.encode(_admin)); | ||
| function _generateSalt(address _admin, bytes memory _data) internal view virtual returns (bytes32) { | ||
| return keccak256(abi.encodePacked(_admin, _data)); |
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
joaquim-verges
approved these changes
Oct 30, 2023
joaquim-verges
left a comment
joaquim-verges
left a comment
Member
There was a problem hiding this comment.
lg. We'll have to update the AccountExtension impl address so just a reminder that it will need to be redeployed on all chains deterministically.
and with the new function selectors added 🙏
| } | ||
|
|
||
| /// @notice Withdraw funds for this account from Entrypoint. | ||
| function withdrawDepositTo(address payable withdrawAddress, uint256 amount) public { |
Member
There was a problem hiding this comment.
remember to add those 2 to the AccountExtension struct in the factory when publishing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.