fix unchecked errors in cmds/exp/netbootxyz & pkg/boot#2539
Merged
Conversation
Codecov ReportBase: 73.88% // Head: 73.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2539 +/- ##
==========================================
- Coverage 73.88% 73.88% -0.01%
==========================================
Files 403 403
Lines 40979 40983 +4
==========================================
+ Hits 30278 30279 +1
- Misses 10701 10704 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rminnich
reviewed
Oct 25, 2022
replace kexec cmd Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
rminnich
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a look at the unchecked errors, found on #2522.
In all the 3 cases, any returned errors from the underlying function should halt the calling function as well.
Replaced the kexec cmd call as well, just use the kexec pkg instead.
Signed-off-by: Fabian Wienand fabian.wienand@9elements.com