Improvement: Make gosh work#2554
Merged
Merged
Conversation
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
…te dependency in u-root Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
ChriMarMe
force-pushed
the
gosh_complete
branch
from
c2d17ad to
085dc08
Compare
Codecov ReportBase: 73.67% // Head: 73.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
==========================================
+ Coverage 73.67% 73.84% +0.16%
==========================================
Files 405 405
Lines 41282 41282
==========================================
+ Hits 30416 30485 +69
+ Misses 10866 10797 -69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rminnich
approved these changes
Nov 11, 2022
rminnich
approved these changes
Nov 11, 2022
rminnich
added
automerge
This was referenced Jan 5, 2023
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gosh crashes when using qemu with -nographic and ttyS0 as output.
Problem is that the used library 'github.com/c-bata/go-prompt' does a ioctlGetWinsize call which returns 0,0 size.
Maintainer of go-prompt does not respond to PRs to fix the issue so the dependency was forked, adapted, got the fix.
This integrates the changes required to fix the issue with tab completion under mentioned circumstance.