Skip to content

Remove old busybox#2584

Merged
rminnich merged 4 commits into
u-root:mainfrom
hugelgupf:delete-makebb
Dec 27, 2022
Merged

Remove old busybox#2584
rminnich merged 4 commits into
u-root:mainfrom
hugelgupf:delete-makebb

Conversation

@hugelgupf

@hugelgupf hugelgupf commented Dec 25, 2022

Copy link
Copy Markdown
Member

Split out of #2583

Signed-off-by: Chris Koch <chrisko@google.com>
@codecov

codecov Bot commented Dec 25, 2022

Copy link
Copy Markdown

Codecov Report

Base: 73.45% // Head: 73.55% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (e339110) compared to base (b02caf1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2584      +/-   ##
==========================================
+ Coverage   73.45%   73.55%   +0.10%     
==========================================
  Files         411      407       -4     
  Lines       41755    41293     -462     
==========================================
- Hits        30670    30374     -296     
+ Misses      11085    10919     -166     
Impacted Files Coverage Δ
pkg/golang/build.go 59.15% <0.00%> (-5.64%) ⬇️
cmds/core/date/date.go 91.60% <0.00%> (+0.76%) ⬆️
cmds/core/ip/ops_linux.go 79.82% <0.00%> (+0.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hugelgupf hugelgupf requested a review from rminnich December 25, 2022 08:43

@rminnich rminnich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does #2583 need to merge before this goes in? I was not totally sure.

@rminnich rminnich added the Awaiting author Waiting for new changes or feedback for author. label Dec 25, 2022
@hugelgupf

Copy link
Copy Markdown
Member Author

does #2583 need to merge before this goes in? I was not totally sure.

no, I'm trying to make #2583 smaller, so I want to merge this first.

@hugelgupf hugelgupf added Awaiting reviewer Waiting for a reviewer. and removed Awaiting author Waiting for new changes or feedback for author. labels Dec 25, 2022
gobusybox is the successor.

Signed-off-by: Chris Koch <chrisko@google.com>
Only used by pkg/bb.

Signed-off-by: Chris Koch <chrisko@google.com>
Tools exist in gobusybox now.

Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf changed the title Rm makebb; replacement in u-root/gobusybox Remove old bb Dec 25, 2022
@hugelgupf hugelgupf changed the title Remove old bb Remove old busybox Dec 25, 2022
@rminnich rminnich merged commit 72a5dc0 into u-root:main Dec 27, 2022
@10000TB

10000TB commented Jan 6, 2023

Copy link
Copy Markdown
Member

during a recent sync of latest, u-root, we found another internal customer is depending this. we are not able to importing latest and passing all tests atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants