Skip to content

cmds/core/time: remove testutil#2602

Merged
rminnich merged 3 commits into
u-root:mainfrom
binjip978:time-removetestutil
Feb 7, 2023
Merged

cmds/core/time: remove testutil#2602
rminnich merged 3 commits into
u-root:mainfrom
binjip978:time-removetestutil

Conversation

@binjip978

Copy link
Copy Markdown
Contributor

Signed-off-by: Siarhiej Siemianczuk pdp.eleven11@gmail.com

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@codecov

codecov Bot commented Jan 11, 2023

Copy link
Copy Markdown

Codecov Report

Base: 74.81% // Head: 74.88% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (116b187) compared to base (4dad982).
Patch coverage: 82.60% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2602      +/-   ##
==========================================
+ Coverage   74.81%   74.88%   +0.07%     
==========================================
  Files         408      408              
  Lines       41371    41380       +9     
==========================================
+ Hits        30950    30986      +36     
+ Misses      10421    10394      -27     
Impacted Files Coverage Δ
cmds/core/time/time.go 85.71% <82.60%> (+85.71%) ⬆️
cmds/core/mv/mv.go 79.54% <0.00%> (+2.27%) ⬆️
pkg/acpi/rsdp_unix.go 86.95% <0.00%> (+4.34%) ⬆️
pkg/acpi/bios.go 27.02% <0.00%> (+27.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Jan 11, 2023
Comment thread cmds/core/time/time.go Outdated
@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Jan 17, 2023
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978 binjip978 added Awaiting reviewer Waiting for a reviewer. and removed Awaiting author Waiting for new changes or feedback for author. labels Jan 19, 2023
@binjip978 binjip978 requested a review from rminnich February 7, 2023 07:38
@rminnich rminnich merged commit bf5a9ac into u-root:main Feb 7, 2023
@rminnich

rminnich commented Feb 7, 2023

Copy link
Copy Markdown
Member

btw ... pdpeleven ... my first unix machine in ... 1976 :-)
Wonderful email :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants