Skip to content

Add correct tags and files such that govulncheck works#2656

Merged
rminnich merged 2 commits into
u-root:mainfrom
rminnich:govulncheck
Apr 17, 2023
Merged

Add correct tags and files such that govulncheck works#2656
rminnich merged 2 commits into
u-root:mainfrom
rminnich:govulncheck

Conversation

@rminnich

Copy link
Copy Markdown
Member

govulncheck now runs with go 1.20.3
rminnich-macbookpro2:u-root rminnich$ GOOS=linux GOARCH=arm64 govulncheck ./... govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using go1.20.3 and govulncheck@v0.0.0-506ee65bc240-20230412201939 with vulnerability data from https://vuln.go.dev (last modified 2023-04-13 00:03:55 +0000 UTC).

Scanning your code and 439 packages across 71 dependent modules for known vulnerabilities... No vulnerabilities found.
rminnich-macbookpro2:u-root rminnich$ GOOS=linux GOARCH=amd64 govulncheck ./... govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using go1.20.3 and govulncheck@v0.0.0-506ee65bc240-20230412201939 with vulnerability data from https://vuln.go.dev (last modified 2023-04-13 00:03:55 +0000 UTC).

Scanning your code and 441 packages across 71 dependent modules for known vulnerabilities... No vulnerabilities found.

@rminnich rminnich added the Awaiting reviewer Waiting for a reviewer. label Apr 14, 2023
@rminnich rminnich requested review from a team, 10000TB and binjip978 April 14, 2023 12:47
Comment thread pkg/strace/syscall_linux_amd64.go Outdated

@10000TB 10000TB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like syscall_linux_armd64.go need a minor fix

@rminnich rminnich force-pushed the govulncheck branch 2 times, most recently from 970ed2b to 3ee617c Compare April 16, 2023 01:10
@rminnich

Copy link
Copy Markdown
Member Author

after this I'll add govulncheck to the list of not-required test steps, which at some point we can make required.

govulncheck now runs with go 1.20.3
rminnich-macbookpro2:u-root rminnich$ GOOS=linux GOARCH=arm64 govulncheck ./...
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using go1.20.3 and govulncheck@v0.0.0-506ee65bc240-20230412201939 with
vulnerability data from https://vuln.go.dev (last modified 2023-04-13 00:03:55 +0000 UTC).

Scanning your code and 439 packages across 71 dependent modules for known vulnerabilities...
No vulnerabilities found.
rminnich-macbookpro2:u-root rminnich$ GOOS=linux GOARCH=amd64 govulncheck ./...
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Using go1.20.3 and govulncheck@v0.0.0-506ee65bc240-20230412201939 with
vulnerability data from https://vuln.go.dev (last modified 2023-04-13 00:03:55 +0000 UTC).

Scanning your code and 441 packages across 71 dependent modules for known vulnerabilities...
No vulnerabilities found.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
@rminnich

Copy link
Copy Markdown
Member Author

looks like syscall_linux_armd64.go need a minor fix

You lost me ... I don't know what you mean ?

@rminnich

Copy link
Copy Markdown
Member Author

looks like syscall_linux_armd64.go need a minor fix

You lost me ... I don't know what you mean ?

Also ... do you mean arm64 or amd64 :-) there is not armd64.go?

@10000TB

10000TB commented Apr 16, 2023

Copy link
Copy Markdown
Member

looks like syscall_linux_armd64.go need a minor fix

You lost me ... I don't know what you mean ?

Also ... do you mean arm64 or amd64 :-) there is not armd64.go?

oh, just echoing to the original comment from @binjip978. not adding anything new

@rminnich rminnich dismissed 10000TB’s stale review April 17, 2023 13:26

it's just echoing another review, already resolved, per comment above.

@rminnich rminnich merged commit f6a61cd into u-root:main Apr 17, 2023
@rminnich rminnich deleted the govulncheck branch April 17, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants