Add correct tags and files such that govulncheck works#2656
Conversation
10000TB
left a comment
There was a problem hiding this comment.
looks like syscall_linux_armd64.go need a minor fix
970ed2b to
3ee617c
Compare
|
after this I'll add govulncheck to the list of not-required test steps, which at some point we can make required. |
govulncheck now runs with go 1.20.3 rminnich-macbookpro2:u-root rminnich$ GOOS=linux GOARCH=arm64 govulncheck ./... govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback. Using go1.20.3 and govulncheck@v0.0.0-506ee65bc240-20230412201939 with vulnerability data from https://vuln.go.dev (last modified 2023-04-13 00:03:55 +0000 UTC). Scanning your code and 439 packages across 71 dependent modules for known vulnerabilities... No vulnerabilities found. rminnich-macbookpro2:u-root rminnich$ GOOS=linux GOARCH=amd64 govulncheck ./... govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback. Using go1.20.3 and govulncheck@v0.0.0-506ee65bc240-20230412201939 with vulnerability data from https://vuln.go.dev (last modified 2023-04-13 00:03:55 +0000 UTC). Scanning your code and 441 packages across 71 dependent modules for known vulnerabilities... No vulnerabilities found. Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
You lost me ... I don't know what you mean ? |
Also ... do you mean arm64 or amd64 :-) there is not armd64.go? |
oh, just echoing to the original comment from @binjip978. not adding anything new |
it's just echoing another review, already resolved, per comment above.
govulncheck now runs with go 1.20.3
rminnich-macbookpro2:u-root rminnich$ GOOS=linux GOARCH=arm64 govulncheck ./... govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.
Using go1.20.3 and govulncheck@v0.0.0-506ee65bc240-20230412201939 with vulnerability data from https://vuln.go.dev (last modified 2023-04-13 00:03:55 +0000 UTC).
Scanning your code and 439 packages across 71 dependent modules for known vulnerabilities... No vulnerabilities found.
rminnich-macbookpro2:u-root rminnich$ GOOS=linux GOARCH=amd64 govulncheck ./... govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.
Using go1.20.3 and govulncheck@v0.0.0-506ee65bc240-20230412201939 with vulnerability data from https://vuln.go.dev (last modified 2023-04-13 00:03:55 +0000 UTC).
Scanning your code and 441 packages across 71 dependent modules for known vulnerabilities... No vulnerabilities found.