Add stdin, stdout, stderr options to StartShell struct#2699
Merged
Conversation
andrewsun2898
force-pushed
the
shell
branch
2 times, most recently
from
4f071ff to
71dc1f2
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2699 +/- ##
=======================================
Coverage 75.42% 75.43%
=======================================
Files 414 414
Lines 42159 42168 +9
=======================================
+ Hits 31800 31811 +11
+ Misses 10359 10357 -2
☔ View full report in Codecov by Sentry. |
MDr164
previously approved these changes
Jun 20, 2023
rminnich
reviewed
Jun 20, 2023
rminnich
left a comment
rminnich
left a comment
Member
There was a problem hiding this comment.
I don't think this is a style we want to use, I'm curious to see what Chris thinks.
andrewsun2898
force-pushed
the
shell
branch
2 times, most recently
from
bd141a5 to
a8d2119
Compare
Allow users to specify stdin, stdout, and stderr options when running the shell. Signed-off-by: Andrew <andrewsun@google.com>
rminnich
approved these changes
Jun 21, 2023
rminnich
left a comment
rminnich
left a comment
Member
There was a problem hiding this comment.
thanks, this feels a bit more in line with other u-root practice.
rminnich
added
the
Awaiting author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to specify stdin, stdout, and stderr options when running the shell.