Change to use 'pxeboot' and 'boot' commands for systemboot since they are better maintained and used#2705
Merged
Merged
Conversation
Contributor
|
@marcjones-syspro made a PR long time ago |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
==========================================
- Coverage 75.40% 75.40% -0.01%
==========================================
Files 414 415 +1
Lines 42257 42326 +69
==========================================
+ Hits 31864 31914 +50
- Misses 10393 10412 +19
☔ View full report in Codecov by Sentry. |
rminnich
reviewed
Jun 27, 2023
rminnich
added
the
Awaiting author
rminnich
reviewed
Jul 5, 2023
rminnich
left a comment
rminnich
left a comment
Member
There was a problem hiding this comment.
thank you for all your patience, there are just a few more things.
johnnylinwiwynn
removed
the
Awaiting author
Adds pxeboot and boot booters. This also makes them the default booters if the VPD is empty. Signed-off-by: Marc Jones <marcjones@sysproconsulting.com>
…ption Replace 'localboot' with 'boot' since it's better maintained. Signed-off-by: Johnny Lin <johnny_lin@wiwynn.com>
Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
…ogger to replace log Because it is not prefer to use log in packages, Use ulog.Logger to replace log. Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
…itch -v Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
…f NullBooter Return (Booter, error) instead of NullBooter when nothing is found, because it is more idiomatic Go style. Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
Signed-off-by: Shelly Chang <Shelly_Chang@wiwynn.com>
rminnich
added
the
Awaiting author
rminnich
approved these changes
Jul 23, 2023
johnnylinwiwynn
removed
the
Awaiting author
rminnich
approved these changes
Jul 27, 2023
rminnich
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.