Skip to content

Fix argument name for shasum command#2709

Merged
hugelgupf merged 1 commit into
u-root:mainfrom
a-urth:main
Jul 27, 2023
Merged

Fix argument name for shasum command#2709
hugelgupf merged 1 commit into
u-root:mainfrom
a-urth:main

Conversation

@a-urth

@a-urth a-urth commented Jun 27, 2023

Copy link
Copy Markdown

Seems like there was a typo

@codecov

codecov Bot commented Jun 27, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.17 ⚠️

Comparison is base (cd15f19) 75.54% compared to head (243c607) 75.38%.

❗ Current head 243c607 differs from pull request most recent head 3167082. Consider uploading reports for the commit 3167082 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2709      +/-   ##
==========================================
- Coverage   75.54%   75.38%   -0.17%     
==========================================
  Files         415      415              
  Lines       42221    42222       +1     
==========================================
- Hits        31896    31829      -67     
- Misses      10325    10393      +68
Impacted Files Coverage Δ
cmds/core/shasum/shasum.go 87.50% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rminnich

rminnich commented Jun 27, 2023

Copy link
Copy Markdown
Member

please git commit --amend -s and we are good to go!

@rminnich rminnich added the Awaiting author Waiting for new changes or feedback for author. label Jun 27, 2023
@a-urth

a-urth commented Jun 28, 2023

Copy link
Copy Markdown
Author

Signed off. Didn't want to push with force, so it produced unnecessary commit. If its not ok, I'll change.

@rminnich rminnich added the automerge Applying this label auto-merges the PR when ready label Jul 2, 2023
@MDr164

MDr164 commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Signed off. Didn't want to push with force, so it produced unnecessary commit. If its not ok, I'll change.

You'll have to force push to change the commit message, otherwise the checks won't pass

@a-urth a-urth force-pushed the main branch 2 times, most recently from a91f18b to fdbdcd2 Compare July 4, 2023 13:04
@hugelgupf
fix arg name for shasum command
43f1b80 
Signed-off-by: Andrii Ursulenko <a.ursulenko@gmail.com>
@hugelgupf

hugelgupf commented Jul 27, 2023

Copy link
Copy Markdown
Member

Thanks for the contribution. I force-pushed to your branch to clean up the conflicting commits, going to merge.

@hugelgupf hugelgupf merged commit 664f388 into u-root:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rminnich rminnich rminnich approved these changes

@MDr164 MDr164 MDr164 approved these changes

Assignees

No one assigned

Labels

automerge Applying this label auto-merges the PR when ready Awaiting author Waiting for new changes or feedback for author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-urth @rminnich @MDr164 @hugelgupf