Skip to content

Update vmtest, expand arm testing#2857

Merged
hugelgupf merged 7 commits into
mainfrom
update-vmtest
Jan 15, 2024
Merged

Update vmtest, expand arm testing#2857
hugelgupf merged 7 commits into
mainfrom
update-vmtest

Conversation

@hugelgupf

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
@codecov

codecov Bot commented Jan 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab35349) 75.68% compared to head (509773e) 75.68%.

❗ Current head 509773e differs from pull request most recent head 90ae695. Consider uploading reports for the commit 90ae695 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2857      +/-   ##
==========================================
- Coverage   75.68%   75.68%   -0.01%     
==========================================
  Files         425      426       +1     
  Lines       42846    42848       +2     
==========================================
- Hits        32430    32429       -1     
- Misses      10416    10419       +3     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.69% <ø> (-0.02%) ⬇️
integration/generic-tests/...-amd64 0.00% <ø> (ø)
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 0.00% <ø> (ø)
integration/gotests/...-amd64 73.98% <0.00%> (+0.03%) ⬆️
integration/gotests/...-arm 75.20% <0.00%> (?)
integration/gotests/...-arm64 74.93% <0.00%> (+0.04%) ⬆️
pkg/...-amd64 76.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf changed the title Update vmtest Update vmtest, expand arm testing Jan 15, 2024
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf marked this pull request as ready for review January 15, 2024 04:59
rminnich
rminnich previously approved these changes Jan 15, 2024

@rminnich rminnich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think strace works on aarch64 (arm64)?

Comment thread integration/gotests/gotest_test.go
@rminnich rminnich added the Awaiting author Waiting for new changes or feedback for author. label Jan 15, 2024
@hugelgupf hugelgupf merged commit 74fd0db into main Jan 15, 2024
@hugelgupf hugelgupf deleted the update-vmtest branch January 15, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting author Waiting for new changes or feedback for author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants