Skip to content

Replace pkg/uio with uio/uio#2896

Merged
hugelgupf merged 2 commits into
u-root:mainfrom
hugelgupf:uio
Feb 6, 2024
Merged

Replace pkg/uio with uio/uio#2896
hugelgupf merged 2 commits into
u-root:mainfrom
hugelgupf:uio

Conversation

@hugelgupf

@hugelgupf hugelgupf commented Feb 5, 2024

Copy link
Copy Markdown
Member

No description provided.

@hugelgupf
Replace pkg/uio with uio/uio
20728a6 
Signed-off-by: Chris Koch <chrisko@google.com>
@codecov

codecov Bot commented Feb 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3ae33f) 77.36% compared to head (20728a6) 77.65%.
Report is 6 commits behind head on main.

❗ Current head 20728a6 differs from pull request most recent head 45d7967. Consider uploading reports for the commit 45d7967 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2896      +/-   ##
==========================================
+ Coverage   77.36%   77.65%   +0.29%     
==========================================
  Files         430      419      -11     
  Lines       43122    42755     -367     
==========================================
- Hits        33360    33203     -157     
+ Misses       9762     9552     -210
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.40% <ø> (ø)
integration/generic-tests/...-amd64 18.20% <ø> (+0.35%) ⬆️
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 22.10% <ø> (+0.49%) ⬆️
integration/gotests/...-amd64 74.83% <ø> (+0.69%) ⬆️
integration/gotests/...-arm 75.99% <ø> (+0.54%) ⬆️
integration/gotests/...-arm64 75.87% <ø> (+0.45%) ⬆️
pkg/...-amd64 76.55% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugelgupf hugelgupf requested a review from a team February 5, 2024 21:37
@hugelgupf hugelgupf enabled auto-merge (rebase) February 5, 2024 21:37
@hugelgupf hugelgupf added the Awaiting reviewer Waiting for a reviewer. label Feb 6, 2024
rminnich
rminnich approved these changes Feb 6, 2024
View reviewed changes

@rminnich rminnich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to worry about external users of u-root; are we going to cause them trouble? Is this a point for a version bump or something?

@hugelgupf

hugelgupf commented Feb 6, 2024

Copy link
Copy Markdown
Member Author

I'm starting to worry about external users of u-root; are we going to cause them trouble? Is this a point for a version bump or something?

IMO vendoring / go modules take care of external users. We may want to start versioning uio?

@hugelgupf hugelgupf merged commit 8ccfc73 into u-root:main Feb 6, 2024
@hugelgupf hugelgupf deleted the uio branch February 6, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rminnich rminnich rminnich approved these changes

Assignees

No one assigned

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugelgupf @rminnich