Skip to content

kexec,memory: some utilities#2903

Merged
hugelgupf merged 1 commit into
u-root:mainfrom
hugelgupf:align
Feb 6, 2024
Merged

kexec,memory: some utilities#2903
hugelgupf merged 1 commit into
u-root:mainfrom
hugelgupf:align

Conversation

@hugelgupf

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf requested a review from a team February 6, 2024 18:26
mm.Insert(TypedRange{
// end is inclusive.
Range: RangeFromInterval(uintptr(start), uintptr(end+1)),
Range: RangeFromInclusiveInterval(uintptr(start), uintptr(end)),

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an unsigned 64-bit integer from [strconv.ParseUint](1) to a lower bit size type uintptr without an upper bound check.
mm.Insert(TypedRange{
// end is inclusive.
Range: RangeFromInterval(uintptr(start), uintptr(end+1)),
Range: RangeFromInclusiveInterval(uintptr(start), uintptr(end)),

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an unsigned 64-bit integer from [strconv.ParseUint](1) to a lower bit size type uintptr without an upper bound check.

// end is inclusive.
r := RangeFromInterval(uintptr(start), uintptr(end+1))
r := RangeFromInclusiveInterval(uintptr(start), uintptr(end))

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an unsigned 64-bit integer from [strconv.ParseUint](1) to a lower bit size type uintptr without an upper bound check.

// end is inclusive.
r := RangeFromInterval(uintptr(start), uintptr(end+1))
r := RangeFromInclusiveInterval(uintptr(start), uintptr(end))

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an unsigned 64-bit integer from [strconv.ParseUint](1) to a lower bit size type uintptr without an upper bound check.
@hugelgupf hugelgupf added the Awaiting reviewer Waiting for a reviewer. label Feb 6, 2024
@hugelgupf hugelgupf enabled auto-merge (rebase) February 6, 2024 19:24
@codecov

codecov Bot commented Feb 6, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8ccfc73) 77.52% compared to head (2d8a099) 77.53%.

Files Patch % Lines
pkg/boot/kexec/memory_linux.go 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2903      +/-   ##
==========================================
+ Coverage   77.52%   77.53%   +0.01%     
==========================================
  Files         419      419              
  Lines       42773    42795      +22     
==========================================
+ Hits        33160    33182      +22     
  Misses       9613     9613              
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.40% <ø> (+0.01%) ⬆️
integration/generic-tests/...-amd64 18.16% <20.00%> (+<0.01%) ⬆️
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 21.61% <0.00%> (-0.14%) ⬇️
integration/gotests/...-amd64 74.66% <92.00%> (+0.01%) ⬆️
integration/gotests/...-arm 76.01% <ø> (ø)
integration/gotests/...-arm64 75.90% <92.00%> (+0.01%) ⬆️
pkg/...-amd64 76.63% <92.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugelgupf hugelgupf merged commit ec02d47 into u-root:main Feb 6, 2024
@hugelgupf hugelgupf deleted the align branch February 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants