update golangci-lint#2908
Conversation
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2908 +/- ##
==========================================
- Coverage 78.22% 78.04% -0.18%
==========================================
Files 421 419 -2
Lines 42893 42793 -100
==========================================
- Hits 33552 33398 -154
- Misses 9341 9395 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
|
redefines-builtin-id probably worth fixing, but it probably should be separate PR. |
|
It'd be nice if we could put this in a golangci-lint yml, and use the golangci-lint github action, which will annotate the PR with code reviews https://github.com/golangci/golangci-lint-action |
yeah, that's a good idea. |
want me to merge this or do you want to do this as well? |
I think it better to merge this right now, and I will come with .conf file in other PR |
No description provided.