Skip to content

update golangci-lint#2908

Merged
hugelgupf merged 4 commits into
u-root:mainfrom
binjip978:cilint
Feb 9, 2024
Merged

update golangci-lint#2908
hugelgupf merged 4 commits into
u-root:mainfrom
binjip978:cilint

Conversation

@binjip978

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978 binjip978 changed the title Cilint update golang-ci-lint Feb 8, 2024
@binjip978 binjip978 changed the title update golang-ci-lint update golangci-lint Feb 8, 2024
@codecov

codecov Bot commented Feb 8, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (245b296) 78.22% compared to head (7cdf4bc) 78.04%.

❗ Current head 7cdf4bc differs from pull request most recent head 8c4a9d6. Consider uploading reports for the commit 8c4a9d6 to get more accurate results

Files Patch % Lines
pkg/uroot/builder/gbb.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
- Coverage   78.22%   78.04%   -0.18%     
==========================================
  Files         421      419       -2     
  Lines       42893    42793     -100     
==========================================
- Hits        33552    33398     -154     
- Misses       9341     9395      +54     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.40% <ø> (ø)
integration/generic-tests/...-amd64 20.26% <ø> (-0.26%) ⬇️
integration/generic-tests/...-arm 50.00% <ø> (+38.29%) ⬆️
integration/generic-tests/...-arm64 24.95% <ø> (+0.96%) ⬆️
integration/gotests/...-amd64 74.66% <ø> (-0.03%) ⬇️
integration/gotests/...-arm 76.01% <ø> (-0.03%) ⬇️
integration/gotests/...-arm64 75.91% <ø> (-0.03%) ⬇️
pkg/...-amd64 76.63% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@binjip978

Copy link
Copy Markdown
Contributor Author

redefines-builtin-id probably worth fixing, but it probably should be separate PR.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Feb 8, 2024
@hugelgupf

Copy link
Copy Markdown
Member

It'd be nice if we could put this in a golangci-lint yml, and use the golangci-lint github action, which will annotate the PR with code reviews https://github.com/golangci/golangci-lint-action

@binjip978

Copy link
Copy Markdown
Contributor Author

It'd be nice if we could put this in a golangci-lint yml, and use the golangci-lint github action, which will annotate the PR with code reviews https://github.com/golangci/golangci-lint-action

yeah, that's a good idea.

@hugelgupf

Copy link
Copy Markdown
Member

It'd be nice if we could put this in a golangci-lint yml, and use the golangci-lint github action, which will annotate the PR with code reviews https://github.com/golangci/golangci-lint-action

yeah, that's a good idea.

want me to merge this or do you want to do this as well?

@binjip978

Copy link
Copy Markdown
Contributor Author

It'd be nice if we could put this in a golangci-lint yml, and use the golangci-lint github action, which will annotate the PR with code reviews https://github.com/golangci/golangci-lint-action

yeah, that's a good idea.

want me to merge this or do you want to do this as well?

I think it better to merge this right now, and I will come with .conf file in other PR

@hugelgupf hugelgupf enabled auto-merge (rebase) February 9, 2024 18:47
@hugelgupf hugelgupf merged commit ea24903 into u-root:main Feb 9, 2024
@binjip978 binjip978 deleted the cilint branch February 9, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants