Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (0befc99) to head (0666964).

@@           Coverage Diff           @@
##             main    #2924   +/-   ##
=======================================
  Coverage   78.11%   78.11%           
=======================================
  Files         430      430           
  Lines       43153    43153           
=======================================
  Hits        33709    33709           
  Misses       9444     9444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binjip978 I can't reproduce the golangci-lint issues locally, can you help?

$ go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.56.2
$ golangci-lint run ./...
$ echo $?
0

@binjip978 I can't reproduce the golangci-lint issues locally, can you help?

$ go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.56.2
$ golangci-lint run ./...
$ echo $?
0

Ah sorry, don't get it right, I will try to look.

@hugelgupf I can't reproduce it locally either with binary or staticcheck. But issue is gone is version will be 1.52.1 or go 1.22, golangci-lint updated 5 days ago, maybe that's related. Maybe we should stick with 1.52.1.

Your PR #2929 but with version change.

This clears up some confusion, but, still, can we just remove them? Is anyone anywhere using them?

Exp is kind of "stuff somebody is using" but there's no evidence anyone is using these, or am I missing something.

I think I'll let @johnnylinwiwynn speak on that. For now, I'll just move them. I see that the system boot command has moved to pxeboot and boot for the most part, with a fallback to fbnetboot. So perhaps we can delete localboot completely?