Skip to content

fix: keeps commenting on every push#153

Merged
JounQin merged 2 commits into
un-ts:mainfrom
alan910127:main
Dec 4, 2023
Merged

fix: keeps commenting on every push#153
JounQin merged 2 commits into
un-ts:mainfrom
alan910127:main

Conversation

@alan910127

@alan910127 alan910127 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Closes #145

Summary

This is mostly reverting #143 while keeping the format of not using ReturnType as the type of parameter of the hasChangesetBeenAdded function.

@changeset-bot

changeset-bot Bot commented Dec 4, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2d7773f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changesets-gitlab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci

codesandbox-ci Bot commented Dec 4, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin

JounQin commented Dec 4, 2023

Copy link
Copy Markdown
Member

No compatible replacement? So this is an upstream issue? Is this a related upstream issue for reference?

@alan910127 I think we should check the version of GitLab instance to determine which method/API should be used. But considering the repeating comments issue, I'll merge this PR first.

@JounQin JounQin merged commit b687dd8 into un-ts:main Dec 4, 2023
@alan910127

Copy link
Copy Markdown
Contributor Author

@JounQin I could try to solve the issue with allDiffs 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

comment adds new comment with every commit

2 participants