Skip to content

fix: Remove double user buttons#6386

Merged
dave-hawkins merged 1 commit into
mainfrom
eng-2885-double-user-buttons-appear-in-production
Jun 9, 2026
Merged

fix: Remove double user buttons#6386
dave-hawkins merged 1 commit into
mainfrom
eng-2885-double-user-buttons-appear-in-production

Conversation

@perkinsjr

Copy link
Copy Markdown
Member

What does this PR do?

Fixes showing two user buttons.

Fixes # (issue)

If there is not an issue for this, create one first. This is used for tracking purposes and helps us understand why this PR exists.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Login and make sure there is only one button.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Internal Workflow Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran mise run fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@linear-code

linear-code Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

ENG-2885

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Jun 9, 2026 1:00am
design Ready Ready Preview, Comment Jun 9, 2026 1:00am

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — a single-file deletion in the dashboard global navbar that removes the duplicate user button shown in production.

  • Remove NavbarUser subcomponent — deletes the GlobalNavbar.User (NavbarUser) forwardRef and its render slot in navbar.tsx, so only the canonical UserButton in top-nav renders.
  • Drop now-unused UserButton import and User interface member — the import { UserButton }, the User property on GlobalNavbarComponent, and the Navbar.User assignment are all removed consistently.

Verified the removal is clean: no callers of Navbar.User / NavbarUser remain anywhere in web/, the canonical UserButton is still rendered in top-nav/index.tsx:48 (and onboarding-content.tsx:30), and the surviving imports (cn, Link, Button) are all still in use, so there's no dangling reference or unused-import fallout.

Pullfrog  | View workflow run | Using Claude Opus𝕏

@dave-hawkins dave-hawkins enabled auto-merge June 9, 2026 05:50

@chronark chronark left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a single user button 👍

@dave-hawkins dave-hawkins added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit 81b6ad9 Jun 9, 2026
15 checks passed
@dave-hawkins dave-hawkins deleted the eng-2885-double-user-buttons-appear-in-production branch June 9, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants