Skip to content

fix(dashboard): gap and size of crumb popover#6406

Merged
ogzhanolguncu merged 6 commits into
mainfrom
fix-gap-and-size-of-crumb-popover
Jun 10, 2026
Merged

fix(dashboard): gap and size of crumb popover#6406
ogzhanolguncu merged 6 commits into
mainfrom
fix-gap-and-size-of-crumb-popover

Conversation

@ogzhanolguncu

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes sizes for crumb popover and reduces spacing between items to match other popovers in the codebase

Screen.Recording.2026-06-10.at.12.37.10.mov

@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Jun 10, 2026 9:47am
design Ready Ready Preview, Comment Jun 10, 2026 9:47am

Request Review

@ogzhanolguncu ogzhanolguncu changed the title Fix gap and size of crumb popover fix(dashboard): gap and size of crumb popover Jun 10, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — a purely visual Tailwind tweak to the breadcrumb popover, tightening row spacing and shrinking text/icon sizes to match other popovers in the codebase.

  • Shrink search input textCommandInput gets text-[13px] plus placeholder:text-[13px] placeholder:text-accent-8 for a smaller, dimmer placeholder.
  • Tighten item rows — item CommandItem className goes from gap-2 to flex items-center gap-2 py-1 mt-0, reducing vertical spacing.
  • Reduce check icon size — removing size-3.5 from the Check icon lets it render at 12px from iconSize="sm-regular" (the size-3.5 CSS was previously overriding the SVG's 12px width/height attributes).
  • Tighten footer rows — both footer variants (Link and bare CommandItem) move to flex items-center gap-2 py-1 mt-0, and the Link variant adds overflow-hidden.

ℹ️ Nitpicks

  • crumb-popover.tsx:139 — the footer Icon still carries size-3.5 (14px) while the item Check icon was reduced to 12px (sm-regular). If the intent was to standardize on sm-regular, the footer icon is now slightly larger than the check mark; otherwise this is fine to leave as-is.

Pullfrog  | View workflow run | Using Claude Opus𝕏

@ogzhanolguncu ogzhanolguncu added this pull request to the merge queue Jun 10, 2026
Merged via the queue into main with commit a73d4f3 Jun 10, 2026
14 checks passed
@ogzhanolguncu ogzhanolguncu deleted the fix-gap-and-size-of-crumb-popover branch June 10, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants