fix(dashboard): z-index issue#6429
Merged
Merged
Conversation
Contributor
ogzhanolguncu
requested review from
MichaelUnkey,
chronark,
dave-hawkins,
mcstepp and
perkinsjr
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — a one-line z-index fix for the dashboard Combobox to restore the dark-mode left icon's visibility (ENG-2901).
- Lift the
leftIconabove the trigger background — addsz-10to the absolutely-positionedleftIconwrapper inweb/apps/dashboard/components/ui/combobox.tsx. The icon is a sibling that precedes thePopoverTriggerbutton in DOM order; the button'sdark:bg-blackbackground painted over it in dark mode, hiding the icon.z-10raises the icon above that background. - Cosmetic reflow — the single-line icon JSX is split across three lines with no behavior change.
The fix is correct and minimal: the icon retains pointer-events-none so clicks still pass through to the trigger, and the portaled PopoverContent uses z-200, so z-10 does not interfere with the dropdown stacking.
Claude Opus ｜ 𝕏
dave-hawkins
approved these changes
Jun 11, 2026
chronark
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENG-2901
Problem:
Absolute icon with no z-index hidden behind the trigger whose bg is transparent in light but dark:bg-black in dark. it was a stacking order bug
Before:
After:
