Avoid checking trying to resolve unknown locations#2805
Open
DavyLandman wants to merge 1 commit into
Open
Conversation
As they would right now fall-back to the externel resolver, but in reality we've marked them as invalid, so they should never have successfull IO results
|
rodinaarssen
approved these changes
Jun 18, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
=======================================
Coverage 46% 46%
- Complexity 6711 6723 +12
=======================================
Files 839 839
Lines 66767 66772 +5
Branches 9983 9983
=======================================
+ Hits 30774 30783 +9
+ Misses 33613 33604 -9
- Partials 2380 2385 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As they would right now fall-back to the external resolver, but in reality we've marked them as invalid, so they should never have successful IO results
I've also removed an old overload in the URI resolver that shouldn't be used anymore (and was only used by a single test).