Skip to content

Suite cache should not be saved for packages that are not suites #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 2 commits into from
Mar 15, 2026
Merged

Suite cache should not be saved for packages that are not suites #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8811d
Added tests to reproduce the issue.
Mar 15, 2026
f3c0d3f
Fixed the problem where `suite_cache_package` and `suite_cache_schema…
Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/core/ut_suite_cache_manager.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ create or replace package body ut_suite_cache_manager is
l_object_owner varchar2(250) := upper(a_object_owner);
l_object_name varchar2(250) := upper(a_object_name);
begin
if a_suite_items is not null and a_suite_items.count = 0 then
if a_suite_items is null or a_suite_items.count = 0 then

delete from ut_suite_cache t
where t.object_owner = l_object_owner
Expand Down
2 changes: 2 additions & 0 deletions test/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ set -ev
#goto git root directory
git rev-parse && cd "$(git rev-parse --show-cdup)"

export NLS_LANG=AMERICAN_AMERICA.AL32UTF8

time utPLSQL-cli/bin/utplsql run UT3_TESTER_HELPER/ut3@//${CONNECTION_STR} -D \
-source_path=source -owner=ut3_develop \
-p='ut3_tester,ut3_user' \
Expand Down
2 changes: 1 addition & 1 deletion test/ut3_tester/core/test_suite_manager.pks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ create or replace package test_suite_manager is

--%context(get_schema_ut_packages)

--%test(returns list of all unit test packages in given schema)
--%test(returns list of all unit test packages in given schema excluding packages that are not suites)
--%beforetest(create_ut3_suite)
--%aftertest(drop_ut3_suite)
procedure test_get_schema_ut_packages;
Expand Down
11 changes: 11 additions & 0 deletions test/ut3_tester_helper/run_helper.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,12 +855,23 @@ create or replace package body run_helper is
--%test
procedure some_test;

end;]';
execute immediate q'[
create or replace package ut3_develop.package_that_is_not_a_test
as
--%parameter(a comment inside)
--%parameters( description )

--%test
procedure some_test;

end;]';
end;

procedure drop_ut3_suite is
pragma autonomous_transaction;
begin
execute immediate q'[drop package ut3_develop.package_that_is_not_a_test]';
execute immediate q'[drop package ut3_develop.some_test_package]';
end;

Expand Down
Loading