Skip to content

[WIP] github: protect the version of actions/checkout used in build-compat job#3894

Draft
masatake wants to merge 1 commit into
util-linux:masterfrom
masatake:ci--protect-build-compat-from-dependabot
Draft

[WIP] github: protect the version of actions/checkout used in build-compat job#3894
masatake wants to merge 1 commit into
util-linux:masterfrom
masatake:ci--protect-build-compat-from-dependabot

Conversation

@masatake

@masatake masatake commented Dec 4, 2025

Copy link
Copy Markdown
Member

Updating action/checkout proposed by the dependabot has caused troubles:
5756e7b,
561f0bb, and
2af05e8.

This change places the original job in a separate file and adds that file to the exclude list.

@masatake masatake changed the title github: protect the build-compat job from dependabot [WIP] github: protect the build-compat job from dependabot Dec 4, 2025
@masatake

masatake commented Dec 4, 2025

Copy link
Copy Markdown
Member Author
image

The name looks too long.

@masatake masatake force-pushed the ci--protect-build-compat-from-dependabot branch from 62d3a6d to 84379a8 Compare December 4, 2025 20:35
@masatake masatake changed the title [WIP] github: protect the build-compat job from dependabot github: protect the version of actions/checkout used in build-compat job Dec 4, 2025
@masatake masatake force-pushed the ci--protect-build-compat-from-dependabot branch from 84379a8 to 09325d5 Compare December 4, 2025 20:36
@masatake masatake marked this pull request as ready for review December 4, 2025 20:37
@masatake masatake force-pushed the ci--protect-build-compat-from-dependabot branch 3 times, most recently from 4180c47 to 0524919 Compare December 4, 2025 20:47
@masatake

masatake commented Dec 4, 2025

Copy link
Copy Markdown
Member Author
image

I'm not sure what this should be.

Comment thread .github/workflows/cibuild.yml Outdated
# update the versions in your source tree. If your actions are in
# a separate file, you can add that file to Dependabot's exclude
# list.
name: call with ${{ matrix.image }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the name is not build ${{ matrix.image }} like we have in other places?

It seems the final name is created (merged) from both names, which means:
build-compat.yml:name / cibuild.yml:call-build-compat:name.

Maybe the cibuild.yml:call-build-compat:name does not have to be set at all. Did you try it?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't set cibuild.yml:call-build-compat:name and set ${{ inputs.image }} to build-compat.yml:name, we get call-build-compat (ubuntu:18.04) / ubuntu:18.04 (pull_request). See the update commit.

@karelzak

karelzak commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/controlling-dependencies-updated

Would it be possible to use in .github/dependabot.yml

ignore:
  - dependency-name: "actions/checkout*"
  - versions: ["v1"]

But I'm absolutely not sure which part of the configuration is the dependency-name we need to address (maybe it's the 'name:` field in the actions). Dependbot supports an 'ignore:' option to exclude certain things, but ...

@masatake masatake force-pushed the ci--protect-build-compat-from-dependabot branch from 0524919 to c02d8ee Compare December 10, 2025 21:04
Updating action/checkout proposed by the dependabot has caused troubles:
5756e7b,
561f0bb, and
2af05e8.

This change places the original job in a separate file and
adds that file to the exclude list.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake force-pushed the ci--protect-build-compat-from-dependabot branch from c02d8ee to 14d9892 Compare December 10, 2025 21:07
@masatake

masatake commented Dec 10, 2025

Copy link
Copy Markdown
Member Author
ignore:
  - dependency-name: "actions/checkout*"
  - versions: ["v1"]

OK. I will try the way that modifies only dependabot.yml file in my repository.

@masatake masatake marked this pull request as draft December 10, 2025 21:21
@masatake masatake changed the title github: protect the version of actions/checkout used in build-compat job [WIP] github: protect the version of actions/checkout used in build-compat job Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants