tests: handle ENOSYS in multiplexing syscall tests#4425
Merged
Conversation
On ppc64le, __NR_select is defined at compile time, so test_mkfds -W lists "select" as available. However, the kernel returns ENOSYS at runtime. The helper process prints its PID, then calls select() which fails immediately with ENOSYS. This creates a race where the bash script's kill -0 liveness check can succeed while the process is still dying, causing lsfd to run against a dead process and produce wrong output. Exit with EXIT_ENOSYS (23) instead of EXIT_FAILURE when the multiplexer syscall returns ENOSYS. This applies to both DEFUN_WAIT_EVENT_SELECT and DEFUN_WAIT_EVENT_POLL macros. In the bash test, check the wait exit code for 23 after the coproc finishes and skip the subtest cleanly. Signed-off-by: Karel Zak <kzak@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__NR_selectis defined at compile time but the kernel returnsENOSYS at runtime, causing the
lsfd/mkfds-multiplexingtest to fail due toa race between the helper process dying and the bash script checking its state
EXIT_ENOSYS(23) from bothDEFUN_WAIT_EVENT_SELECTandDEFUN_WAIT_EVENT_POLLmacros when the multiplexer syscall returns ENOSYS