Skip to content

Add support for -print0#123

Merged
sylvestre merged 1 commit into
uutils:mainfrom
refi64:print02
Jan 23, 2022
Merged

Add support for -print0#123
sylvestre merged 1 commit into
uutils:mainfrom
refi64:print02

Conversation

@refi64

@refi64 refi64 commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Ryan Gonzalez ryan.gonzalez@collabora.com


I admittedly had this ready for a bit now, but I knew it would have merge conflicts with #120 so just waited until that was in first

@codecov

codecov Bot commented Jan 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #123 (4d9ede3) into main (bdfd492) will increase coverage by 0.09%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   49.80%   49.90%   +0.09%     
==========================================
  Files          19       19              
  Lines        2594     2603       +9     
  Branches      702      704       +2     
==========================================
+ Hits         1292     1299       +7     
  Misses       1046     1046              
- Partials      256      258       +2     
Impacted Files Coverage Δ
src/find/mod.rs 61.36% <ø> (ø)
src/find/matchers/mod.rs 65.65% <75.00%> (-0.14%) ⬇️
src/find/matchers/printer.rs 95.00% <92.30%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdfd492...4d9ede3. Read the comment docs.

Comment thread src/find/matchers/printer.rs Outdated
@refi64

refi64 commented Jan 10, 2022

Copy link
Copy Markdown
Contributor Author

Fixed clippy now (really I should be used to running that already)

@sylvestre

Copy link
Copy Markdown
Contributor

could you please rebase this patch to compare with the other testsuite? (I don't know why github isn't allowing this in the interface)

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
@sylvestre

Copy link
Copy Markdown
Contributor

Nice:
Warning: Congrats! The bfs test test_print0 is now passing!

@sylvestre sylvestre merged commit 96b353b into uutils:main Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants